Add line counting to DiffCommits

Review Request #6934 — Created Feb. 11, 2015 and submitted

brennie
Review Board
dvcs
6815
6943
a1fa795...
reviewboard

The line counting functionality in the DiffSet model has been
refactored into a mixin. This helper function is now used to calculate
the line counts in the DiffCommit model as well.

Ran unit tests.

Description From Last Updated

Please add a blank line after the class docstring.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
  2. 
      
chipx86
  1. Code looks good. I have a suggestion though, to simplify things just a bit. Since both functions using this have the same signature and the same expectations, how about a DiffLineCountsMixin class?

  2. 
      
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/diffviewer/models.py (Diff revision 2)
     
     
     

    Please add a blank line after the class docstring.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (19cb6c8)
Loading...