Add line counting to DiffCommits
Review Request #6934 — Created Feb. 11, 2015 and submitted
The line counting functionality in the
DiffSetmodel has been
refactored into a mixin. This helper function is now used to calculate
the line counts in theDiffCommitmodel as well.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Please add a blank line after the class docstring. |
 david
|
-
Code looks good. I have a suggestion though, to simplify things just a bit. Since both functions using this have the same signature and the same expectations, how about a
DiffLineCountsMixinclass?
- Change Summary:
-
Refactored into mixin instead of helper function.
- Description:
-
The line counting functionality in the
DiffSetmodel has been~ refactored into a helper function. This helper function is now used to ~ calculate the line counts in the DiffCommitmodel as well.~ refactored into a mixin. This helper function is now used to calculate ~ the line counts in the DiffCommitmodel as well. - Commit:
-
a1fa7952b48c73e02b7a628c00a90d1015dc64f0
- Diff:
-
Revision 2 (+18 -15)
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/models.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/models.py
Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/models.py Tool: Pyflakes Processed Files: reviewboard/diffviewer/models.py