Take the review banner into consideration in diff anchor offsets.

Review Request #6912 — Created Feb. 6, 2015 and submitted

Information

Review Board
release-2.0.x
f6068ba...

Reviewers

A recent change reduced the offset from the top of the page to the
selected anchor in the diff viewer, in order to show more of the diff.
This ended up causing the code to be covered up when showing the review
draft banner.

We now factor in the banner's height when choosing the offset from the
top of the page.

Scrolled through the anchors with the keyboard shortcuts. Saw the small
gap between the top of the page and the anchor.

Added a comment and saw the draft banner appear. Scrolled through some
more, and saw the offset took the banner into consideration.

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (e28e877)
Loading...