Add a Review Board extension to provide a high-level reviews API.

Review Request #6904 — Created Feb. 4, 2015 and submitted

Information

student-sonar
master
9cb23a3...

Reviewers

One thing that stops us from automating some of our reporting on students is
the lack of ability to fetch all reviews done by a given user. This deficiency
exists because the current review list resource is a child of the review
requset resource.

This new extension adds an API resource that can be filtered using ?from-user,
?time-added-to, and ?time-added-from, much like the review request list
resource.

Filled by database with a bunch of fake data (including a lot of reviews by
different users). Fetched this API endpoint using the various query options and
saw that it returned all the reviews done by the given user. Checked to make
sure that the links worked correctly.

Description From Last Updated

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

'webapi_response_errors' imported but unused

reviewbotreviewbot

Period.

brenniebrennie

Why not name this like time-added-end and likewise, name the other field time-added-start?

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        misc/rb-reviews-api/rb_reviews_api/extension.py
        misc/rb-reviews-api/rb_reviews_api/resources.py
        misc/rb-reviews-api/setup.py
    
    Ignored Files:
        misc/rb-reviews-api/rb_reviews_api/__init__.py
        .gitignore
    
    
    
    Tool: Pyflakes
    Processed Files:
        misc/rb-reviews-api/rb_reviews_api/extension.py
        misc/rb-reviews-api/rb_reviews_api/resources.py
        misc/rb-reviews-api/setup.py
    
    Ignored Files:
        misc/rb-reviews-api/rb_reviews_api/__init__.py
        .gitignore
    
    
  2. Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  3. Show all issues
     'webapi_response_errors' imported but unused
    
  4. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        misc/rb-reviews-api/rb_reviews_api/extension.py
        misc/rb-reviews-api/rb_reviews_api/resources.py
        misc/rb-reviews-api/setup.py
    
    Ignored Files:
        misc/rb-reviews-api/rb_reviews_api/__init__.py
        .gitignore
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        misc/rb-reviews-api/rb_reviews_api/extension.py
        misc/rb-reviews-api/rb_reviews_api/resources.py
        misc/rb-reviews-api/setup.py
    
    Ignored Files:
        misc/rb-reviews-api/rb_reviews_api/__init__.py
        .gitignore
    
    
  2. 
      
brennie
  1. 
      
  2. Show all issues

    Period.

  3. Show all issues

    Why not name this like time-added-end and likewise, name the other field time-added-start?

    1. This is to match the existing names in the review-request-list resource.

  4. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        misc/rb-reviews-api/rb_reviews_api/extension.py
        misc/rb-reviews-api/rb_reviews_api/resources.py
        misc/rb-reviews-api/setup.py
    
    Ignored Files:
        misc/rb-reviews-api/rb_reviews_api/__init__.py
        .gitignore
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        misc/rb-reviews-api/rb_reviews_api/extension.py
        misc/rb-reviews-api/rb_reviews_api/resources.py
        misc/rb-reviews-api/setup.py
    
    Ignored Files:
        misc/rb-reviews-api/rb_reviews_api/__init__.py
        .gitignore
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
mike_conley
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (4672b23)
Loading...