Summary

Add a Review Board extension to provide a high-level reviews API.

Review Request #6904 — Created Feb. 4, 2015 and submitted Feb. 9, 2015, 5:02 p.m.

Information

Owner

david

Repository

student-sonar

Branch

master

Bugs

Depends On

Commit

9cb23a3...

Reviewers

Groups

student-sonar

People

Description

One thing that stops us from automating some of our reporting on students is
the lack of ability to fetch all reviews done by a given user. This deficiency
exists because the current review list resource is a child of the review
requset resource.

This new extension adds an API resource that can be filtered using ?from-user,
?time-added-to, and ?time-added-from, much like the review request list
resource.

Testing Done

Filled by database with a bunch of fake data (including a lot of reviews by
different users). Fetched this API endpoint using the various query options and
saw that it returned all the reviews done by the given user. Checked to make
sure that the links worked correctly.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Feb. 4, 2015, 2:21 p.m.
'webapi_response_errors' imported but unused	reviewbot	Feb. 4, 2015, 2:21 p.m.
Period.	brennie	Feb. 6, 2015, 1:13 p.m.
Why not name this like time-added-end and likewise, name the other field time-added-start?	brennie	Feb. 6, 2015, 1:13 p.m.

Tool: PEP8 Style Checker
Processed Files:
    misc/rb-reviews-api/rb_reviews_api/extension.py
    misc/rb-reviews-api/rb_reviews_api/resources.py
    misc/rb-reviews-api/setup.py

Ignored Files:
    misc/rb-reviews-api/rb_reviews_api/__init__.py
    .gitignore



Tool: Pyflakes
Processed Files:
    misc/rb-reviews-api/rb_reviews_api/extension.py
    misc/rb-reviews-api/rb_reviews_api/resources.py
    misc/rb-reviews-api/setup.py

Ignored Files:
    misc/rb-reviews-api/rb_reviews_api/__init__.py
    .gitignore

misc/rb-reviews-api/rb_reviews_api/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
misc/rb-reviews-api/rb_reviews_api/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'webapi_response_errors' imported but unused
```

Commit:

fca216119d6f814d1a0f636640d51352406d5546

df42e2b550ab1d2b91bc54c88d07bbc0c6111cb8

Diff:

Revision 2 (+117)

Show changes

	.gitignore
	misc/rb-reviews-api/setup.py
	misc/rb-reviews-api/rb_reviews_api/__init__.py
	misc/rb-reviews-api/rb_reviews_api/extension.py
	misc/rb-reviews-api/rb_reviews_api/resources.py

Tool: Pyflakes
Processed Files:
    misc/rb-reviews-api/rb_reviews_api/extension.py
    misc/rb-reviews-api/rb_reviews_api/resources.py
    misc/rb-reviews-api/setup.py

Ignored Files:
    misc/rb-reviews-api/rb_reviews_api/__init__.py
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    misc/rb-reviews-api/rb_reviews_api/extension.py
    misc/rb-reviews-api/rb_reviews_api/resources.py
    misc/rb-reviews-api/setup.py

Ignored Files:
    misc/rb-reviews-api/rb_reviews_api/__init__.py
    .gitignore

misc/rb-reviews-api/rb_reviews_api/resources.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Period.
```

misc/rb-reviews-api/rb_reviews_api/resources.py (Diff revision 2)

The issue has been dropped. Show all issues

Why not name this like time-added-end and likewise, name the other field time-added-start?

david Feb. 6, 2015, 1:13 p.m.

This is to match the existing names in the review-request-list resource.

Commit:

df42e2b550ab1d2b91bc54c88d07bbc0c6111cb8

9cb23a321b0dcc675693dc8d20df79cacc41f5b7

Diff:

Revision 3 (+117)

Show changes

	.gitignore
	misc/rb-reviews-api/setup.py
	misc/rb-reviews-api/rb_reviews_api/__init__.py
	misc/rb-reviews-api/rb_reviews_api/extension.py
	misc/rb-reviews-api/rb_reviews_api/resources.py

Tool: Pyflakes
Processed Files:
    misc/rb-reviews-api/rb_reviews_api/extension.py
    misc/rb-reviews-api/rb_reviews_api/resources.py
    misc/rb-reviews-api/setup.py

Ignored Files:
    misc/rb-reviews-api/rb_reviews_api/__init__.py
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    misc/rb-reviews-api/rb_reviews_api/extension.py
    misc/rb-reviews-api/rb_reviews_api/resources.py
    misc/rb-reviews-api/setup.py

Ignored Files:
    misc/rb-reviews-api/rb_reviews_api/__init__.py
    .gitignore

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (4672b23)