Reword authentication-settings.rst Description
Review Request #6894 — Created Feb. 3, 2015 and submitted
| Information | |
|---|---|
| seanchain | |
| Review Board | |
| master | |
| 3636 | |
| 398bcc8... | |
| Reviewers | |
| reviewboard, students | |
When the user want to read the manuals, they build their manuals file authentication-settings.html and find out that the description about authentication settings dosent't tell them what to do if they can't login successfully.
I have add extra lines in the
authentication-settings.rstfile, and after the user build the manuals, and if they can't login successfully, they will know what to do through from theauthentication-settings.htmlfile.
I've build the manual docs using
make htmland get the_build/html/admin/configuration/authentication-settings.htmland the format of the html file looks just good to me.
| Description | From | Last Updated |
|---|---|---|
|
Undo this change. |
 brennie
|
|
|
This line is too long. Lines for .rst files are limited to 79 characters in width. |
brennie
|
|
|
This change still needs to be reverted. |
 mike_conley
|
|
|
Should be "fully qualified name" |
 david
|
|
|
typo: "fullly" -> "fully" |
mike_conley
|
|
|
Please remove this added line. |
david
|
|
|
We generally avoid using "please" in the manual. How about "If you can't login, you may need to use the … |
david
|
-
Please remove the issue number from the description and add it to the
bugsfield. It will be automatically added when the patch is landed. Also please add thestudentsgroup.In addition, please read through https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/ and update the description and summary.
-
-
docs/manual/admin/configuration/authentication-settings.rst (Diff revision 1) This line is too long. Lines for
.rstfiles are limited to 79 characters in width.
SE
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Bugs: |
|
||||||||||||
Commit: |
|
||||||||||||
Groups: |
|
||||||||||||
Diff: |
Revision 2 (+4) |
-
Tool: Pyflakes Ignored Files: docs/manual/admin/configuration/authentication-settings.rst Tool: PEP8 Style Checker Ignored Files: docs/manual/admin/configuration/authentication-settings.rst
-
For the
bugsfield, we don't need the#mark, just3636will suffice. We also don't need the easyFix label in there, either
-
Hey Sean,
You have several open issues on this review request - you can see them in yellow just below the review request details. You're likely not getting additional reviews because you still have open issues that haven't been marked Fixed or Dropped.
Please go through your open issues and mark them accordingly.
Also, please read this document on writing good change descriptions. Please also add any testing you've done (when making a documentation change, we expect you to build the documentation to make sure your changes look right. Building the docs can be done by running:
make htmlinside docs/manual).
-
docs/manual/admin/configuration/authentication-settings.rst (Diff revision 2) This change still needs to be reverted.
SE
Description: |
|
|||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
-
-
docs/manual/admin/configuration/authentication-settings.rst (Diff revision 2) Should be "fully qualified name"
SE
Change Summary:
Change some descriptions
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+4) |
-
Tool: Pyflakes Ignored Files: docs/manual/admin/configuration/authentication-settings.rst Tool: PEP8 Style Checker Ignored Files: docs/manual/admin/configuration/authentication-settings.rst
-
-
docs/manual/admin/configuration/authentication-settings.rst (Diff revision 3) typo: "fullly" -> "fully"
SE
Change Summary:
Changed a typo.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+4) |
-
Tool: PEP8 Style Checker Ignored Files: docs/manual/admin/configuration/authentication-settings.rst Tool: Pyflakes Ignored Files: docs/manual/admin/configuration/authentication-settings.rst
-
-
docs/manual/admin/configuration/authentication-settings.rst (Diff revision 4) Please remove this added line.
-
docs/manual/admin/configuration/authentication-settings.rst (Diff revision 4) We generally avoid using "please" in the manual. How about "If you can't login, you may need to use the fully qualified domain name"?
SE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+3) |
Tool: Pyflakes Ignored Files: docs/manual/admin/configuration/authentication-settings.rst Tool: PEP8 Style Checker Ignored Files: docs/manual/admin/configuration/authentication-settings.rst