Make double-clicking on a row in a diff create a comment.

Review Request #6881 — Created Feb. 1, 2015 and submitted

mike_conley
Review Board
master
900f7e2...
reviewboard

Users of GitHub or Bugzilla Splinter might be more used to creating
comments on diffs by double-clicking on the line of code they want
to comment on. This patch adds that capability.

In a diff, I double-clicked on both sides of a diff, both within syntax-highlighted regions, and outside of syntax-highlighted regions. The comment editor dialog opened in all cases, as expected.

Description From Last Updated

Remove trailing comma

mike_conleymike_conley

Add documentation here.

mike_conleymike_conley

Is it worth adding a separate class for the code cells to check the ancestors for?

mike_conleymike_conley

Add documentation

mike_conleymike_conley

Add documentation

mike_conleymike_conley

Blank line between these.

brenniebrennie

There should be a single var statement at the top of the function.

brenniebrennie

Can you break this off into a summary/description?

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/textCommentRowSelector.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/textCommentRowSelector.js
    
    
  2. 
      
mike_conley
  1. 
      
  2. Add documentation here.

  3. Is it worth adding a separate class for the code cells to check the ancestors for?

    1. We'll see what the others think.

    2. I've simplified this by checking ancestors for td.l and td.r.

  4. 
      
mike_conley
  1. 
      
  2. Remove trailing comma

  3. 
      
brennie
  1. 
      
  2. Blank line between these.

  3. There should be a single var statement at the top of the function.

  4. 
      
mike_conley
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/textCommentRowSelector.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/textCommentRowSelector.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
  1. I haven't looked at the code yet, but does this cover bug 3437?

    1. Not intentionally, no. Though I can't seem to reproduce 3437 with or without my patch.

    2. I think you should close that bug once this is pushed.

  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Can you break this off into a summary/description?

  3. 
      
mike_conley
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/textCommentRowSelector.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/textCommentRowSelector.js
    
    
  2. 
      
mike_conley
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (90f3011)
Loading...