Make double-clicking on a row in a diff create a comment.
Review Request #6881 — Created Feb. 1, 2015 and submitted
Users of GitHub or Bugzilla Splinter might be more used to creating
comments on diffs by double-clicking on the line of code they want
to comment on. This patch adds that capability.
In a diff, I double-clicked on both sides of a diff, both within syntax-highlighted regions, and outside of syntax-highlighted regions. The comment editor dialog opened in all cases, as expected.
| Description | From | Last Updated |
|---|---|---|
|
Remove trailing comma |
 mike_conley
|
|
|
Add documentation here. |
mike_conley
|
|
|
Is it worth adding a separate class for the code cells to check the ancestors for? |
mike_conley
|
|
|
Add documentation |
mike_conley
|
|
|
Add documentation |
mike_conley
|
|
|
Blank line between these. |
 brennie
|
|
|
There should be a single var statement at the top of the function. |
brennie
|
|
|
Can you break this off into a summary/description? |
 chipx86
|
- Summary:
-
[WIP] Make double-clicking on a row in a diff create a comment.Make double-clicking on a row in a diff create a comment.
- Description:
-
Users of GitHub or Bugzilla Splinter might be more used to creating
comments on diffs by double-clicking on the line of code they want to comment on. This patch adds that capability. - - Question: Do we want to detect the first time the user does this, and
- have the comment balloon offer up a link to documentation on how to - select a range of lines to comment on? - Commit:
-
8d8aa218b7aed4ae7b30144b81c80cee701dc3561376723cbea71f39aa24782bf46d5c0318d1a2b9
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/textCommentRowSelector.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/textCommentRowSelector.js
- Testing Done:
-
~ Just local testing at this point. In a diff, I double-clicked on both sides of a diff, both within syntax-highlighted regions, and outside of syntax-highlighted regions. The comment editor dialog opened in all cases, as expected.
~ In a diff, I double-clicked on both sides of a diff, both within syntax-highlighted regions, and outside of syntax-highlighted regions. The comment editor dialog opened in all cases, as expected.
- Commit:
-
1376723cbea71f39aa24782bf46d5c0318d1a2b9900f7e2891b1f3f8add75b3e3eb98435082c10f9
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/textCommentRowSelector.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/textCommentRowSelector.js