Added Manifest

Review Request #6862 — Created Jan. 31, 2015 and discarded

rmeringe
Review Board
release-2.0.x
reviewboard, students

Fixed bug 3698, by converting string to bytestring.

Passes all tests excepts line endings. Also works on the server.

Description From Last Updated

Pretty sure that we don't want this either.

brenniebrennie

We probably don't want this. :)

mike_conleymike_conley
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    Ignored Files:
        test
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    Ignored Files:
        test
    
    
  2. 
      
RM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    Ignored Files:
        test
        reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    Ignored Files:
        test
        reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads
    
    
  2. 
      
mike_conley
  1. 
      
  2. test (Diff revision 2)
     
     

    We probably don't want this. :)

  3. 
      
RM
mike_conley
  1. Hey Rohan, would you mind fleshing out the Change Description and Testing Done sections a bit more, following this doc?

  2. 
      
brennie
  1. 
      
  2. Pretty sure that we don't want this either.

  3. 
      
RM
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
RM
Review request changed

Status: Discarded

Loading...