Added Manifest
Review Request #6862 — Created Jan. 31, 2015 and discarded
Fixed bug 3698, by converting string to bytestring.
Passes all tests excepts line endings. Also works on the server.
| Description | From | Last Updated |
|---|---|---|
|
Pretty sure that we don't want this either. |
 brennie
|
|
|
We probably don't want this. :) |
 mike_conley
|
RM
Change Summary:
Removed test file
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+4 -1) |
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/models.py Ignored Files: test reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/models.py Ignored Files: test reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads
-
Hey Rohan, would you mind fleshing out the Change Description and Testing Done sections a bit more, following this doc?
-
-
reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads (Diff revision 2) Pretty sure that we don't want this either.
RM
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+3 -7) |
Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/models.py Ignored Files: test Tool: Pyflakes Processed Files: reviewboard/diffviewer/models.py Ignored Files: test