Summary

Added Manifest

Review Request #6862 — Created Jan. 31, 2015 and discarded March 4, 2015, 3:32 p.m.

Information

Owner

rmeringe

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Fixed bug 3698, by converting string to bytestring.

Testing Done

Passes all tests excepts line endings. Also works on the server.

Issues

Description	From	Last Updated
Pretty sure that we don't want this either.	brennie	Feb. 14, 2015, 2:48 p.m.
We probably don't want this. :)	mike_conley	Jan. 31, 2015, 6:36 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py

Ignored Files:
    test



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py

Ignored Files:
    test

Change Summary:

Removed test file

Commit:

b29729df35eee68915afeb727c4b2ff90899fbbd

d1107d82fa6332e59e7605b0da33d0fb6aede6e2

Diff:

Revision 2 (+4 -1)

Show changes

	test
	reviewboard/diffviewer/models.py
	reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py

Ignored Files:
    test
    reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py

Ignored Files:
    test
    reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads

Fix it!

test (Diff revision 2)
An issue was opened. Show all issues
```
We probably don't want this. :)
```

Groups:: students

Hey Rohan, would you mind fleshing out the Change Description and Testing Done sections a bit more, following this doc?

Fix it!

reviewboard/scmtools/testdata/hg_repo/.hg/cache/branchheads (Diff revision 2)
An issue was opened. Show all issues
```
Pretty sure that we don't want this either.
```

Commit:

d1107d82fa6332e59e7605b0da33d0fb6aede6e2

56ffe9c71dcd31fa60ab09f1db0c398f6cb8de6e

Diff:

Revision 3 (+3 -7)

Show changes

reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Status:: Discarded

test (Diff revision 2)