-
-
rbtools/utils/console.py (Diff revision 1) local variable 'return_code' is assigned to but never used
-
Catch editor exiting with nonzero status
Review Request #6843 — Created Jan. 31, 2015 and discarded
| Information | |
|---|---|
| tbelaire | |
| RBTools | |
| master | |
| Reviewers | |
| rbtools, students | |
Now edit_text doesn't try and read the temp file if the editor launches, but
exits with a nonzero status code.
I need a hand here, it looks like edit_text is only called from merge, and I'm not sure how rbt merge works.
This should not ship till I test this.
| Description | From | Last Updated |
|---|---|---|
|
local variable 'return_code' is assigned to but never used |
 reviewbot
|
|
|
undefined name 'neturn_code' |
reviewbot
|
|
|
I don't know what exception type is appropriate here. It's either an error with the editor, or the user wanting … |
TB tbelaire | |
|
"go" -> "use" Period after intentionally. "in the meantime" -> "previously" |
 brennie
|
|
|
Should we print this here, or should we leave this up to the caller to print an error message (perhaps … |
brennie
|
|
|
This should be in the past tense (e.g., "User aborted the editor.") |
brennie
|
TB
Change Summary:
typo fix.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+8 -1) |
-
Tool: Pyflakes Processed Files: rbtools/utils/console.py Tool: PEP8 Style Checker Processed Files: rbtools/utils/console.py
TB
-
-
rbtools/utils/console.py (Diff revisions 1 - 2) I don't know what exception type is appropriate here. It's either an error with the editor, or the user wanting to abort.
-
-
rbtools/utils/console.py (Diff revision 2) "go" -> "use"
Period after intentionally.
"in the meantime" -> "previously"
-
rbtools/utils/console.py (Diff revision 2) Should we print this here, or should we leave this up to the caller to print an error message (perhaps with more context)?
-
rbtools/utils/console.py (Diff revision 2) This should be in the past tense (e.g., "User aborted the editor.")
Tool: Pyflakes Processed Files: rbtools/utils/console.py Tool: PEP8 Style Checker Processed Files: rbtools/utils/console.py