Summary

Catch editor exiting with nonzero status

Review Request #6843 — Created Jan. 31, 2015 and discarded March 31, 2016, 3:02 p.m.

Information

Owner

tbelaire

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools, students

People

Description

Now edit_text doesn't try and read the temp file if the editor launches, but
exits with a nonzero status code.

Testing Done

I need a hand here, it looks like edit_text is only called from merge, and I'm not sure how rbt merge works.

This should not ship till I test this.

Issues

Description	From	Last Updated
local variable 'return_code' is assigned to but never used	reviewbot	Jan. 31, 2015, 7:58 a.m.
undefined name 'neturn_code'	reviewbot	Jan. 31, 2015, 7:58 a.m.
I don't know what exception type is appropriate here. It's either an error with the editor, or the user wanting …	TB tbelaire	Jan. 31, 2015, 7:59 a.m.
"go" -> "use" Period after intentionally. "in the meantime" -> "previously"	brennie	March 17, 2015, 2:33 p.m.
Should we print this here, or should we leave this up to the caller to print an error message (perhaps …	brennie	March 17, 2015, 2:33 p.m.
This should be in the past tense (e.g., "User aborted the editor.")	brennie	March 17, 2015, 2:33 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/utils/console.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/console.py

rbtools/utils/console.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'return_code' is assigned to but never used
```
rbtools/utils/console.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'neturn_code'
```

Change Summary:

typo fix.

Commit:

5d5189354664988354c5a9289dd511a807bff6a1

33a6c0c080b954267e24f82b1f2e76c9ad2ebbcc

Diff:

Revision 2 (+8 -1)

Show changes

rbtools/utils/console.py

Tool: Pyflakes
Processed Files:
    rbtools/utils/console.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/console.py

Fix it!

rbtools/utils/console.py (Diff revisions 1 - 2)

An issue was opened. Show all issues

I don't know what exception type is appropriate here. It's either an error with the editor, or the user wanting to abort.

mike_conley Feb. 8, 2015, 3:30 p.m.

I wonder if "RuntimeError" is more appropriate. Or perhaps we can create our own subclass of StandardError for this particular case.

tbelaire Feb. 8, 2015, 7:41 p.m.

My personal rule of thumb is that you aren't actually re-using it, or catching it anywhere, it's likely overkill to make a new class. Runtime error sounds good to me.

Groups:: students

Fix it!

rbtools/utils/console.py (Diff revision 2)

An issue was opened. Show all issues

"go" -> "use"
Period after intentionally.
"in the meantime" -> "previously"

rbtools/utils/console.py (Diff revision 2)

An issue was opened. Show all issues

Should we print this here, or should we leave this up to the caller to print an error message (perhaps with more context)?

rbtools/utils/console.py (Diff revision 2)
An issue was opened. Show all issues
```
This should be in the past tense (e.g., "User aborted the editor.")
```

```
Ping?
```

Status:: Discarded