Turn off path quoting for git diffs.

Review Request #6835 — Created Jan. 28, 2015 and submitted

Information

RBTools
release-0.6.x
2638f27...

Reviewers

If a filename in a git diff uses complex unicode characters (such as CJK),
instead of including those characters in the diff header, the utf-8 encoded
bytes will be escaped using a \decimal syntax. This syntax is really difficult
to disentangle on the server side without writing our own parser. Luckily, it's
pretty easy to turn off this quoting.

Created a file called "??\test" and ran rbt diff and rbt post. Saw that
the diff it was posting no longer included escaped bytes.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/git.py
    
    
  2. 
      
chipx86
  1. Can we get a unit test for this?

    1. I don't really think there's a good way to test for this.

  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (ac0aa18)
Loading...