Fix Unicode issues with Python on Windows.

Review Request #6834 — Created Jan. 28, 2015 and submitted

Information

RBTools
release-0.7.x
3e73226...

Reviewers

The Windows build of Python appears to be more strict when it comes to
Unicode vs. byte strings in certain cases. In particular, their
implementation of getpass() expects byte strings for the prompt, and
their subprocess.Popen expects an environment dictionary with byte
strings. Unicode strings, in these cases, cause exceptions to be raised.

We now mark these as byte strings, satisfying the Windows
implementation.

Had some Windows users try these changes. They verified they were able to
supply their credentials and post changes for review successfully.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/process.py
        rbtools/commands/__init__.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/utils/process.py
        rbtools/commands/__init__.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (3e05f91)
Loading...