Fix Unicode issues with Python on Windows.
Review Request #6834 — Created Jan. 28, 2015 and submitted
The Windows build of Python appears to be more strict when it comes to
Unicode vs. byte strings in certain cases. In particular, their
implementation ofgetpass()
expects byte strings for the prompt, and
theirsubprocess.Popen
expects an environment dictionary with byte
strings. Unicode strings, in these cases, cause exceptions to be raised.We now mark these as byte strings, satisfying the Windows
implementation.
Had some Windows users try these changes. They verified they were able to
supply their credentials and post changes for review successfully.