Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/diffFragmentQueueView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/diffFragmentQueueView.js
Fix scrolling and controls in diff fragments
Review Request #6832 — Created Jan. 26, 2015 and submitted
Previously, when scrolling into an expanded diff fragment from below,
the diff collapse button would disappear off the screen if the diff
fragment took up the entire height of the browser. This was due to the
outerHeightmethod on the button being treated as a value and not a
Fix an erroneous call to
_isMouseOverContainerwhich should be
_isMouseOverTargetContainer. This fixes a bug where the controls
would not hide sometimes after an expand or collapse finished and the
mouse wasn't over the expanded container.
Tested scrolling upwards and downwards into an expanded diff fragment
in Firefox, Safari, and Chrome on Mac OS X. It worked as expected.
Code looks good!
Couple typos in the description: "into an expanded ...", "disappear off the screen", and "erroneous". Can you make sure those are fixed up here and in the commit message?