Summary

Fix scrolling and controls in diff fragments

Review Request #6832 — Created Jan. 26, 2015 and submitted Jan. 27, 2015, 10:12 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

3a0c9d3...

Reviewers

Groups

reviewboard

People

Description

Previously, when scrolling into an expanded diff fragment from below,
the diff collapse button would disappear off the screen if the diff
fragment took up the entire height of the browser. This was due to the
outerHeight method on the button being treated as a value and not a
function.

Fix an erroneous call to _isMouseOverContainer which should be
_isMouseOverTargetContainer. This fixes a bug where the controls
would not hide sometimes after an expand or collapse finished and the
mouse wasn't over the expanded container.

Testing Done

Tested scrolling upwards and downwards into an expanded diff fragment
in Firefox, Safari, and Chrome on Mac OS X. It worked as expected.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/diffFragmentQueueView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/diffFragmentQueueView.js

Code looks good!

Couple typos in the description: "into an expanded ...", "disappear off the screen", and "erroneous". Can you make sure those are fixed up here and in the commit message?

Change Summary:: Fix typos
Description:: ~
Previously, when scrolling into a expanded diff fragment from below, the
~ diff collapse button would disappear of the screen if the diff fragment
~ took up the entire height of the browser. This was due to the
~
Previously, when scrolling into an expanded diff fragment from below,
~ the diff collapse button would disappear off the screen if the diff
~ fragment took up the entire height of the browser. This was due to the
outerHeight method on the button being treated as a value and not a
function.

~
Fix an erronous call to _isMouseOverContainer which should be
~ _isMouseOverTargetContainer. This fixes a bug where the controls would
~ not hide sometimes after an expand or collapse finished and the mouse
~ wasn't over the expanded container.
~
Fix an erroneous call to _isMouseOverContainer which should be
~ _isMouseOverTargetContainer. This fixes a bug where the controls
~ would not hide sometimes after an expand or collapse finished and the
~ mouse wasn't over the expanded container.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (f135cd8)

~		Previously, when scrolling into a expanded diff fragment from below, the
~		diff collapse button would disappear of the screen if the diff fragment
~		took up the entire height of the browser. This was due to the
	~	Previously, when scrolling into an expanded diff fragment from below,
	~	the diff collapse button would disappear off the screen if the diff
	~	fragment took up the entire height of the browser. This was due to the
		`outerHeight` method on the button being treated as a value and not a
		function.

~		Fix an erronous call to `_isMouseOverContainer` which should be
~		`_isMouseOverTargetContainer`. This fixes a bug where the controls would
~		not hide sometimes after an expand or collapse finished and the mouse
~		wasn't over the expanded container.
	~	Fix an erroneous call to `_isMouseOverContainer` which should be
	~	`_isMouseOverTargetContainer`. This fixes a bug where the controls
	~	would not hide sometimes after an expand or collapse finished and the
	~	mouse wasn't over the expanded container.