Summary

rb-gateway

Review Request #6831 — Created Jan. 25, 2015 and submitted Feb. 20, 2015, 12:57 p.m.

Information

Owner

jyuen

Repository

rb-gateway

Branch

master

Bugs

Depends On

Commit

ba391ab...

Reviewers

Groups

rb-gateway, students

People

Description

This is the beginnings of the rb-gateway project. It is meant to extend existing ReviewBoard functionalities to provide better support for repositories.

Currently, this is a wireframe set up using Google Go, and the git2go library for better Git support.

Structure is as followed:
- repository.go : Base repository structure and interface
- git_repository.go : The Git implementation of repository.go
- routes.go : Handles all web services and routing
- util.go : Handles configuration loading and repository lookup
- sample_config.json : Sample configuration file using .json format
- main.go : main() lives here, access logging
- auth.go : Basic Auth implementation
- session.go : Represents the current user session

Local use case:
1. Specify repo_name = path in config.json (see sample config)
2. Specify credentials in config.json
3. Specify the port you want the server to run on
2. After the server is started, go to ./localhost:<port>?repo=repo_name&id=sha
3. A file should download containing the requested blob.

Link the old review request before pointing to rb-gateway: https://reviews.reviewboard.org/r/6825/

The server uses Basic Auth. Currently authenticating against a single user in the config file, this may need to change. Basic Auth expects the username:password combination in the /session path, and then encrypts that information and stores it in a session. The encrypted information is stored as a PRIVATE-TOKEN (similiar to the Gitlab API), and is expected in future http requests.

Routes are available for getting file blob and checking file existance based on either the Git revision, or the Git commit id, file path pair. It currently does not support other SCM aside from Git.

Testing Done

Authentication:
- curl -u username:password http://localhost:8002/session returns 200 OK and the PRIVATE-TOKEN
- Set up a repository succesfully in RB using a valid user / pass combo, and saw the access log in rb-gateway

File and File Exists
- Tested the following paths via browser, review board, and curl for HEAD and GET methods; returned expected values for valid requests:
- http://localhost:8002/file?id=<revision-sha> (returned 200 OK, and file blob if GET)
- http://localhost:8002/file?commit=<commit>&path=<path> (returned 200 OK, and file blob if GET)

Issues

Description	From	Last Updated
Can you do this? cmd := exec.Command("git", "show", id) cmd.Dir = repo.Path ... Same above.	david	Jan. 26, 2015, 8:04 p.m.
Can you add a default case to log an error?	david	Jan. 26, 2015, 8:04 p.m.
How about storing the "Repos" var as a map from name to repo?	david	Jan. 26, 2015, 8:04 p.m.
These should actually be the same URL (and the same handler). Inside the handler, we can switch between "get file" …	david	Jan. 26, 2015, 8:04 p.m.
Just a nit pick, but underlines with = and - in Markdown should be the same length as the text …	brennie	Jan. 26, 2015, 10:19 p.m.
Can we call this FileExists? (remove the "Get")	david	Jan. 29, 2015, 10:12 p.m.
It might be nice to log the URLs that are accessed and the resulting response status/payload size (kind of an …	david	Jan. 29, 2015, 10:12 p.m.
These two lines could be combined (if repo.GetFileExists(id) {)	david	Jan. 29, 2015, 10:12 p.m.
As I read through this, I'm wondering if instead of logging, we should make this function return the error (use …	david	Jan. 31, 2015, 11:12 a.m.
This is pretty verbose. Can we just have a single line in the log? (get rid of the =====s)	david	Jan. 31, 2015, 11:12 a.m.
To be honest, this comment doesn't really add anything useful (the method name is quite self-explanatory).	david	Jan. 31, 2015, 11:12 a.m.
Does this need to be exported? It looks like we don't use it outside of this file. That said, it …	david	Jan. 31, 2015, 11:12 a.m.
These cases can probably be combined (we expect either an err or a blob)	david	Jan. 31, 2015, 8:03 p.m.
Instead of grabbing github master, how about using "gopkg.in/libgit2/git2go.v22"? That way people building this can just do go get to …	david	Feb. 17, 2015, 5:07 p.m.
These two comments don't really add very much (it's pretty easy to find these functions in a relatively small codebase, …	david	Feb. 17, 2015, 5:07 p.m.
This doesn't need to be exported out of this file.	david	Feb. 17, 2015, 5:07 p.m.
This doesn't need to be exported out of this file.	david	Feb. 17, 2015, 5:07 p.m.
This doesn't need to be exported out of this file.	david	Feb. 17, 2015, 5:07 p.m.
This doesn't seem to provide any advantage over just calling json.Marshal(session) directly.	david	Feb. 17, 2015, 5:07 p.m.
Can you make sure that there's always a space after a colon?	david	Feb. 18, 2015, 12:45 p.m.
You have an "scm" field in the repositories in the config. That seems like a more reliable way of detecting …	david	Feb. 18, 2015, 11:15 p.m.

Tool: Pyflakes
Ignored Files:
    git_repository.go
    repository.go
    main.go
    web_service.go
    util.go
    config.json



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    repository.go
    main.go
    web_service.go
    util.go
    config.json

Change Summary:

Ran go fmt for better formatting

Commit:

-	5821dfa19396e43763c093c1ad5f37b804dce016
+	b7f1cfc2785c740afdfd8fbaf5dc50a4461fb494

Diff:

Revision 2 (+194)

Show changes

	config.json
	git_repository.go
	main.go
	repository.go
	util.go
	web_service.go

Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    repository.go
    main.go
    web_service.go
    util.go
    config.json



Tool: Pyflakes
Ignored Files:
    git_repository.go
    repository.go
    main.go
    web_service.go
    util.go
    config.json

git_repository.go (Diff revision 2)

The issue has been resolved. Show all issues

Can you do this?

cmd := exec.Command("git", "show", id)
cmd.Dir = repo.Path
...


Same above.

jyuen Jan. 26, 2015, 8:05 p.m.

I may use git2go as Barret suggested since executing shell commands are generally unsafe.

util.go (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you add a default case to log an error?
```

util.go (Diff revision 2)

The issue has been resolved. Show all issues

How about storing the "Repos" var as a map from name to repo?

web_service.go (Diff revision 2)

The issue has been resolved. Show all issues

These should actually be the same URL (and the same handler). Inside the handler, we can switch between "get file" and "get file exists" by checking whether r.Method is "GET" or "HEAD", respectively.

Change Summary:

Fixing issues and general improvements + git2go integration and README

Commit:

-	b7f1cfc2785c740afdfd8fbaf5dc50a4461fb494
+	1fea0ac5c663c5510bb3b660d57bd2165afe8d6d

Diff:

Revision 3 (+261)

Show changes

	README.md
	config.json
	git_repository.go
	main.go
	repository.go
	util.go
	web_service.go

Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    repository.go
    main.go
    web_service.go
    util.go
    config.json
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository.go
    repository.go
    main.go
    web_service.go
    util.go
    config.json
    README.md

Change Summary:

Adding .gitignore and putting config.json there

Commit:

-	1fea0ac5c663c5510bb3b660d57bd2165afe8d6d
+	895fd606123a2f764cf99fef0608a88b2a17648e

Diff:

Revision 4 (+257)

Show changes

	.gitignore
	README.md
	git_repository.go
	main.go
	repository.go
	util.go
	web_service.go

Tool: Pyflakes
Ignored Files:
    git_repository.go
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md

README.md (Diff revision 4)

The issue has been resolved. Show all issues

Just a nit pick, but underlines with = and - in Markdown should be the same length as the text they are underlining. Same below.

jyuen Jan. 26, 2015, 9:25 p.m.

With the font I'm using in Sublime, they are the same length :( Is there a standard font when it comes to these things?

brennie Jan. 26, 2015, 9:28 p.m.
```
Switch to any Monospaced font.
```

Change Summary:

Updated description

Description:

		This is the beginnings of the rb-gateway project. It is meant to extend existing ReviewBoard functionalities to provide better support for repositories.

~		Currently, this is a wireframe set up using Google Go (no additional frameworks).
	~	Currently, this is a wireframe set up using Google Go, and the git2go library for better Git support.

		Structure is as followed:
		- repository.go : Base repository structure and interface
		- git_repository.go : The Git implementation of repository.go
		- web_service.go : Handles all web services and routing
		- util.go : Handles configuration loading and repository lookup
~		- config.json : Sample configuration file using .json format
	~	- sample_config.json : Sample configuration file using .json format
		- main.go : main() lives here

		Currently as a test, the web server runs on port 8888. A sample works as follows:
		1. Specify repo_name = path in config.json (see file attachment)
		2. After the server is started, go to ./localhost:8888?repo=repo_name&id=sha
~		3. A file should download, however my shell exec command isn't currently working in Go - need to fix.
	~	3. A file should download containing the requested blob.

~		Link the old review request (with non-addressed issues): https://reviews.reviewboard.org/r/6825/
	~	Link the old review request before pointing to rb-gateway: https://reviews.reviewboard.org/r/6825/

Change Summary:

Adding install instructions to README

Commit:

-	895fd606123a2f764cf99fef0608a88b2a17648e
+	7005548c2042ed91d54a26191ef8323ae5d87a4c

Diff:

Revision 5 (+282)

Show changes

	.gitignore
	README.md
	git_repository.go
	main.go
	repository.go
	sample_config.json
	util.go
	web_service.go

Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md

git_repository.go (Diff revision 5)
The issue has been resolved. Show all issues
```
Can we call this FileExists? (remove the "Get")
```

web_service.go (Diff revision 5)

The issue has been resolved. Show all issues

It might be nice to log the URLs that are accessed and the resulting response status/payload size (kind of an access log).

web_service.go (Diff revision 5)

The issue has been resolved. Show all issues

These two lines could be combined (if repo.GetFileExists(id) {)

Change Summary:

Added access log and fixed David's suggestions.

Commit:

-	7005548c2042ed91d54a26191ef8323ae5d87a4c
+	d5a8c39ac5b11005e27e9e348fbdfbf20064422d

Diff:

Revision 6 (+311)

Show changes

	.gitignore
	README.md
	git_repository.go
	main.go
	repository.go
	sample_config.json
	util.go
	web_service.go

Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md

git_repository.go (Diff revision 6)

The issue has been resolved. Show all issues

As I read through this, I'm wondering if instead of logging, we should make this function return the error (use the typical data, err pattern of returns that go uses). That way we can have a single log statement in the code that calls this method.

main.go (Diff revision 6)

The issue has been resolved. Show all issues

This is pretty verbose. Can we just have a single line in the log? (get rid of the =====s)

main.go (Diff revision 6)

The issue has been resolved. Show all issues

To be honest, this comment doesn't really add anything useful (the method name is quite self-explanatory).

util.go (Diff revision 6)

The issue has been resolved. Show all issues

Does this need to be exported? It looks like we don't use it outside of this file.

That said, it might be nice to change this so that LoadConfig returns this instead of storing it as a global.

Change Summary:

Minor code refactoring

Commit:

-	d5a8c39ac5b11005e27e9e348fbdfbf20064422d
+	de4c4960b7fe2934698419c48ecf20a5c6e61958

Diff:

Revision 7 (+312)

Show changes

	.gitignore
	README.md
	git_repository.go
	main.go
	repository.go
	sample_config.json
	util.go
	web_service.go

Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md

web_service.go (Diff revision 7)

The issue has been resolved. Show all issues

These cases can probably be combined (we expect either an err or a blob)

Change Summary:

Slight refactoring (to fix David's issue)

Commit:

-	de4c4960b7fe2934698419c48ecf20a5c6e61958
+	a38f2d29d0549d467f4e967918958f8ea1707061

Diff:

Revision 8 (+309)

Show changes

	.gitignore
	README.md
	git_repository.go
	main.go
	repository.go
	sample_config.json
	util.go
	web_service.go

Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md

Change Summary:

Added a GetPath to web_service.go

Commit:

-	a38f2d29d0549d467f4e967918958f8ea1707061
+	076e4734d54e4069bd252190ea82b1a1cd4509ff

Diff:

Revision 9 (+331)

Show changes

	.gitignore
	README.md
	git_repository.go
	main.go
	repository.go
	sample_config.json
	util.go
	web_service.go

Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md

Change Summary:

Modified GET path to account for /info/ref that RB adds to the repository GET request

Description:

		This is the beginnings of the rb-gateway project. It is meant to extend existing ReviewBoard functionalities to provide better support for repositories.

		Currently, this is a wireframe set up using Google Go, and the git2go library for better Git support.

		Structure is as followed:
		- repository.go : Base repository structure and interface
		- git_repository.go : The Git implementation of repository.go
		- web_service.go : Handles all web services and routing
		- util.go : Handles configuration loading and repository lookup
		- sample_config.json : Sample configuration file using .json format
		- main.go : main() lives here

		Currently as a test, the web server runs on port 8888. A sample works as follows:
		1. Specify repo_name = path in config.json (see file attachment)
		2. After the server is started, go to ./localhost:8888?repo=repo_name&id=sha
		3. A file should download containing the requested blob.

		Link the old review request before pointing to rb-gateway: https://reviews.reviewboard.org/r/6825/
	+
	+	Update Feb 1, 2015:
	+	Service now is now capable of listening for RB requests if rb-gateway is running on localhost:8888. I still need to add in a config for this.

Commit:

-	076e4734d54e4069bd252190ea82b1a1cd4509ff
+	c00ca725f3bb9d70208020e35254d2662419b6ce

Diff:

Revision 10 (+332)

Show changes

	.gitignore
	README.md
	git_repository.go
	main.go
	repository.go
	sample_config.json
	util.go
	web_service.go

Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    .gitignore
    main.go
    web_service.go
    util.go
    README.md

Change Summary:

Added Basic Auth, port value to configuration, and some clean up

Description:

		This is the beginnings of the rb-gateway project. It is meant to extend existing ReviewBoard functionalities to provide better support for repositories.

		Currently, this is a wireframe set up using Google Go, and the git2go library for better Git support.

		Structure is as followed:
		- repository.go : Base repository structure and interface
		- git_repository.go : The Git implementation of repository.go
~		- web_service.go : Handles all web services and routing
	~	- routes.go : Handles all web services and routing
		- util.go : Handles configuration loading and repository lookup
		- sample_config.json : Sample configuration file using .json format
~		- main.go : main() lives here
	~	- main.go : main() lives here, access logging
	+	- auth.go : Basic Auth implementation
	+	- session.go : Represents the current user session

		Currently as a test, the web server runs on port 8888. A sample works as follows:
		1. Specify repo_name = path in config.json (see file attachment)
		2. After the server is started, go to ./localhost:8888?repo=repo_name&id=sha
		3. A file should download containing the requested blob.

		Link the old review request before pointing to rb-gateway: https://reviews.reviewboard.org/r/6825/

		Update Feb 1, 2015:
		Service now is now capable of listening for RB requests if rb-gateway is running on localhost:8888. I still need to add in a config for this.
	+
	+	Update Feb 5, 2015:
	+	Adding Basic Auth, port configuration in config file. Currently authenticating against a single user in the config file; need to change when I have more time. Basic Auth expects the username:password combination in the /session path, and then encrypts that information and stores it in a session. The encrypted information is stored as a PRIVATE-TOKEN (similiar to the Gitlab API), and is expected in future http requests.

Testing Done:

	+	Authentication:
	+	- curl -u username:password http://localhost:8888/session returns 200 OK and the PRIVATE-TOKEN
	+	- Set up a repository succesfully in RB using a valid user / pass combo, and saw the access log in rb-gateway

Commit:

-	c00ca725f3bb9d70208020e35254d2662419b6ce
+	e222396195689c8077f18669cca541c0a2346f63

Diff:

Revision 11 (+468)

Show changes

	.gitignore
	README.md
	auth.go
	git_repository.go
	main.go
	repository.go
	routes.go
	sample_config.json
	2 more

Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md

Change Summary:

Getting file blob and checking file existance based on commit id, file path pairing (in addition to already supported revision id)

Description:

		This is the beginnings of the rb-gateway project. It is meant to extend existing ReviewBoard functionalities to provide better support for repositories.

		Currently, this is a wireframe set up using Google Go, and the git2go library for better Git support.

		Structure is as followed:
		- repository.go : Base repository structure and interface
		- git_repository.go : The Git implementation of repository.go
		- routes.go : Handles all web services and routing
		- util.go : Handles configuration loading and repository lookup
		- sample_config.json : Sample configuration file using .json format
		- main.go : main() lives here, access logging
		- auth.go : Basic Auth implementation
		- session.go : Represents the current user session

		Currently as a test, the web server runs on port 8888. A sample works as follows:
		1. Specify repo_name = path in config.json (see file attachment)
		2. After the server is started, go to ./localhost:8888?repo=repo_name&id=sha
		3. A file should download containing the requested blob.

		Link the old review request before pointing to rb-gateway: https://reviews.reviewboard.org/r/6825/

		Update Feb 1, 2015:
		Service now is now capable of listening for RB requests if rb-gateway is running on localhost:8888. I still need to add in a config for this.

		Update Feb 5, 2015:
		Adding Basic Auth, port configuration in config file. Currently authenticating against a single user in the config file; need to change when I have more time. Basic Auth expects the username:password combination in the /session path, and then encrypts that information and stores it in a session. The encrypted information is stored as a PRIVATE-TOKEN (similiar to the Gitlab API), and is expected in future http requests.
	+
	+	Update Feb 12, 2015:
	+	Added routes for getting file blob and checking file existance based on commit id, file path pair.

Testing Done:

		Authentication:
		- curl -u username:password http://localhost:8888/session returns 200 OK and the PRIVATE-TOKEN
		- Set up a repository succesfully in RB using a valid user / pass combo, and saw the access log in rb-gateway
	+
	+	File and File Exists
	+	- Tested the following paths via browser, review board, and curl for HEAD and GET methods; returned expected values for valid requests:
	+	- http://localhost:8002/file?id=<revision-sha> (returned 200 OK, and file blob if GET)
	+	- http://localhost:8002/file?commit=<commit>&path=<path> (returned 200 OK, and file blob if GET)

Commit:

-	e222396195689c8077f18669cca541c0a2346f63
+	7d018e4c6f3c01148649a7b3a5b187a3f5458ad7

Diff:

Revision 12 (+567)

Show changes

	.gitignore
	README.md
	auth.go
	git_repository.go
	main.go
	repository.go
	routes.go
	sample_config.json
	2 more

Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md

Change Summary:

Updated description / testing done a bit / removed WIP

Summary:

-	[WIP] rb-gateway
+	rb-gateway

Description:

		This is the beginnings of the rb-gateway project. It is meant to extend existing ReviewBoard functionalities to provide better support for repositories.

		Currently, this is a wireframe set up using Google Go, and the git2go library for better Git support.

		Structure is as followed:
		- repository.go : Base repository structure and interface
		- git_repository.go : The Git implementation of repository.go
		- routes.go : Handles all web services and routing
		- util.go : Handles configuration loading and repository lookup
		- sample_config.json : Sample configuration file using .json format
		- main.go : main() lives here, access logging
		- auth.go : Basic Auth implementation
		- session.go : Represents the current user session

~		Currently as a test, the web server runs on port 8888. A sample works as follows:
~		1. Specify repo_name = path in config.json (see file attachment)
~		2. After the server is started, go to ./localhost:8888?repo=repo_name&id=sha
	~	Local use case:
	~	1. Specify repo_name = path in config.json (see sample config)
	~	2. Specify credentials in config.json
	+	3. Specify the port you want the server to run on
	+	2. After the server is started, go to ./localhost:<port>?repo=repo_name&id=sha
		3. A file should download containing the requested blob.

		Link the old review request before pointing to rb-gateway: https://reviews.reviewboard.org/r/6825/

~		Update Feb 1, 2015:
	~	The server uses Basic Auth. Currently authenticating against a single user in the config file, this may need to change. Basic Auth expects the username:password combination in the /session path, and then encrypts that information and stores it in a session. The encrypted information is stored as a PRIVATE-TOKEN (similiar to the Gitlab API), and is expected in future http requests.
-		Service now is now capable of listening for RB requests if rb-gateway is running on localhost:8888. I still need to add in a config for this.

~		Update Feb 5, 2015:
	~	Routes are available for getting file blob and checking file existance based on either the Git revision, or the Git commit id, file path pair. It currently does not support other SCM aside from Git.
-		Adding Basic Auth, port configuration in config file. Currently authenticating against a single user in the config file; need to change when I have more time. Basic Auth expects the username:password combination in the /session path, and then encrypts that information and stores it in a session. The encrypted information is stored as a PRIVATE-TOKEN (similiar to the Gitlab API), and is expected in future http requests.
-
-		Update Feb 12, 2015:
-		Added routes for getting file blob and checking file existance based on commit id, file path pair.

Testing Done:

		Authentication:
~		- curl -u username:password http://localhost:8888/session returns 200 OK and the PRIVATE-TOKEN
	~	- curl -u username:password http://localhost:8002/session returns 200 OK and the PRIVATE-TOKEN
		- Set up a repository succesfully in RB using a valid user / pass combo, and saw the access log in rb-gateway

		File and File Exists
		- Tested the following paths via browser, review board, and curl for HEAD and GET methods; returned expected values for valid requests:
		- http://localhost:8002/file?id=<revision-sha> (returned 200 OK, and file blob if GET)
		- http://localhost:8002/file?commit=<commit>&path=<path> (returned 200 OK, and file blob if GET)

This is looking really solid!

Can you go through the comments for things and make sure that they follow these conventions: http://blog.golang.org/godoc-documenting-go-code ?

jyuen Feb. 17, 2015, 5:09 p.m.

I added a comment to every exported function and made sure the comment started with the function name. Also un-capitalized consts and some things that didn't need to be exported. Hopefully didn't miss anything.

git_repository.go (Diff revision 12)

The issue has been resolved. Show all issues

Instead of grabbing github master, how about using "gopkg.in/libgit2/git2go.v22"? That way people building this can just do go get to grab the dependency rather than the complicated git/make/etc steps.

main.go (Diff revision 12)

The issue has been resolved. Show all issues

These two comments don't really add very much (it's pretty easy to find these functions in a relatively small codebase, and other than that they just repeat the function name)

routes.go (Diff revision 12)
The issue has been resolved. Show all issues
```
This doesn't need to be exported out of this file.
```
routes.go (Diff revision 12)
The issue has been resolved. Show all issues
```
This doesn't need to be exported out of this file.
```
routes.go (Diff revision 12)
The issue has been resolved. Show all issues
```
This doesn't need to be exported out of this file.
```

session.go (Diff revision 12)

The issue has been resolved. Show all issues

This doesn't seem to provide any advantage over just calling json.Marshal(session) directly.

Change Summary:

Changes to comments and naming conventions, to be more Go-ish.

Commit:

-	7d018e4c6f3c01148649a7b3a5b187a3f5458ad7
+	7d26f59cfda219a1ebf9da452745b59e396b4c23

Diff:

Revision 13 (+591)

Show changes

	.gitignore
	README.md
	auth.go
	git_repository.go
	main.go
	repository.go
	routes.go
	sample_config.json
	2 more

Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md

sample_config.json (Diff revision 13)

The issue has been resolved. Show all issues

Can you make sure that there's always a space after a colon?

util.go (Diff revision 13)

The issue has been resolved. Show all issues

You have an "scm" field in the repositories in the config. That seems like a more reliable way of detecting the repository type.

jyuen Feb. 17, 2015, 7:06 p.m.

I actually removed the scm field from config.json, I forgot to update sample_config.json. The scm field isn't being used.

My local config.json looks like this:
{
"port":8002,
"username":"myuser",
"password":"mypass",
"repositories":[
{"name":"testrepo", "path":"/home/j/git-sandbox/.git"}
]
}

I was thinking without it, it would be more reliable to verify that the path points to a SCM controlled repository (ensuring it ends in .git and what not). I'm not too sure, which do you prefer?

david Feb. 18, 2015, 2:11 p.m.

I think I prefer having it explicitly listed. Not every SCM is as easily discernible from the filename.

Change Summary:

Minor changes to sample_config.json (Added space afer colon)

Commit:

-	7d26f59cfda219a1ebf9da452745b59e396b4c23
+	f7516d8d983a8a1bb2a1d29b1267e601c926d5be

Diff:

Revision 14 (+591)

Show changes

	.gitignore
	README.md
	auth.go
	git_repository.go
	main.go
	repository.go
	routes.go
	sample_config.json
	2 more

Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md

Change Summary:

Added SCM types back to sample_config.json

Commit:

-	f7516d8d983a8a1bb2a1d29b1267e601c926d5be
+	ba391abc49d62a59fb02a8174cc1ed2f97d6781e

Diff:

Revision 15 (+595)

Show changes

	.gitignore
	README.md
	auth.go
	git_repository.go
	main.go
	repository.go
	routes.go
	sample_config.json
	2 more

Tool: Pyflakes
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository.go
    sample_config.json
    repository.go
    auth.go
    .gitignore
    main.go
    session.go
    routes.go
    util.go
    README.md

Ship it!

This looks great to me. Is there anything else you wanted to change before I land this patch?

jyuen Feb. 19, 2015, 9:54 p.m.

I don't think so. I'll work on the API's for the post commit UIs next, but I'll open another rr for that. :)

Status: Closed (submitted)

Change Summary:

Pushed to master (23beb03)