HTTP Digest Authentication: Added ability to edit profile settings

Review Request #6826 — Created Jan. 23, 2015 and discarded

Information

Review Board
master

Reviewers

Added the ability to specify default values for the users First Name, Last Name and Email. Also enabled the fields on the profile page so that users can set their name and email as these values cannot be obtained from the digest file. Though this would be useful as when you get emails from reviewboard the from field is blank and the name is not populated either.

Tested editing users profile settings and tested logging in with a new user and the defaults were applied. Also tested this on the dev server at work. All works fine.

Description From Last Updated

Col: 80 E501 line too long (90 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 33 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 37 E241 multiple spaces after ':'

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/accounts/forms/auth.py
        reviewboard/admin/siteconfig.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
        reviewboard/accounts/forms/auth.py
        reviewboard/admin/siteconfig.py
    
    
  2. reviewboard/accounts/forms/auth.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (90 > 79 characters)
    
  3. reviewboard/accounts/forms/auth.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. reviewboard/accounts/forms/auth.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  5. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Col: 33
     E241 multiple spaces after ':'
    
  6. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Col: 37
     E241 multiple spaces after ':'
    
  7. 
      
chipx86
  1. Thanks for the contribution! I'm trying to better understand it, though. It looks like every user will end up with the same e-mail address and full name? That doesn't seem useful beyond a one-user install.

    1. It was more so that then people notice and then change their details instead of leaving it blank.

  2. 
      
TE
Review request changed

Status: Discarded

Loading...