Summary

HTTP Digest Authentication: Added ability to edit profile settings

Review Request #6826 — Created Jan. 23, 2015 and discarded April 6, 2015, 5:20 a.m.

Information

Owner

terrycain

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Added the ability to specify default values for the users First Name, Last Name and Email. Also enabled the fields on the profile page so that users can set their name and email as these values cannot be obtained from the digest file. Though this would be useful as when you get emails from reviewboard the from field is blank and the name is not populated either.

Testing Done

Tested editing users profile settings and tested logging in with a new user and the defaults were applied. Also tested this on the dev server at work. All works fine.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Jan. 23, 2015, 11:06 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Jan. 23, 2015, 11:06 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Jan. 23, 2015, 11:06 a.m.
Col: 33 E241 multiple spaces after ':'	reviewbot	Jan. 23, 2015, 12:29 p.m.
Col: 37 E241 multiple spaces after ':'	reviewbot	Jan. 23, 2015, 12:29 p.m.

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/accounts/forms/auth.py
    reviewboard/admin/siteconfig.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/accounts/forms/auth.py
    reviewboard/admin/siteconfig.py

reviewboard/accounts/forms/auth.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```
reviewboard/accounts/forms/auth.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
reviewboard/accounts/forms/auth.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 33
 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 37
 E241 multiple spaces after ':'
```

Thanks for the contribution! I'm trying to better understand it, though. It looks like every user will end up with the same e-mail address and full name? That doesn't seem useful beyond a one-user install.

terrycain Jan. 23, 2015, 11:10 a.m.

It was more so that then people notice and then change their details instead of leaving it blank.

Status:: Discarded