-
-
reviewboard/accounts/backends.py (Diff revision 1) Col: 27 E128 continuation line under-indented for visual indent
-
reviewboard/accounts/backends.py (Diff revision 1) Col: 27 E128 continuation line under-indented for visual indent
-
-
-
Added http digest authentication backend
Review Request #6812 — Created Jan. 19, 2015 and submitted
| Information | |
|---|---|
| terrycain | |
| Review Board | |
| master | |
| 5449fbf... | |
| Reviewers | |
| reviewboard | |
Added an authentication backend to allow Review Board to use http digest files for authentication. Added a settings form so that you can specify the location of the file and the realm used for digest auth.
Have tested it with various digest password files in the format of username:realm:passwordhash where the password hash is comprised of the MD5 hash of "user:realm:pass". Files can be created using htdigest.
| Description | From | Last Updated |
|---|---|---|
|
Col: 27 E128 continuation line under-indented for visual indent |
 reviewbot
|
|
|
Col: 27 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 33 E241 multiple spaces after ':' |
reviewbot
|
|
|
Col: 25 E241 multiple spaces after ':' |
reviewbot
|
|
|
'is_release' imported but unused |
reviewbot
|
|
|
We might as well import this at the top. |
 david
|
|
|
Can you use the older printf-style formatting here, and pass in line_no as an argument to the logging function? We … |
david
|
|
|
We should include the exception in this log entry. |
david
|
|
|
Col: 33 E241 multiple spaces after ':' |
reviewbot
|
|
|
Col: 25 E241 multiple spaces after ':' |
reviewbot
|
|
|
'is_release' imported but unused |
reviewbot
|
|
|
Col: 33 E241 multiple spaces after ':' |
reviewbot
|
|
|
Col: 25 E241 multiple spaces after ':' |
reviewbot
|
|
|
'is_release' imported but unused |
reviewbot
|
TE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+74 -1) |
-
Tool: Pyflakes Processed Files: reviewboard/accounts/backends.py reviewboard/accounts/forms/auth.py setup.py reviewboard/admin/management/sites.py reviewboard/admin/siteconfig.py Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/backends.py reviewboard/accounts/forms/auth.py setup.py reviewboard/admin/management/sites.py reviewboard/admin/siteconfig.py -
-
-
-
-
-
reviewboard/accounts/backends.py (Diff revision 2) Can you use the older printf-style formatting here, and pass in
line_noas an argument to the logging function?We should also include the exception.
For example:
except ValueError as e: logging.error("Error in password file, does not " "contain a user, realm, and password " "at line %d: %s", line_no, e, exc_info=True) -
reviewboard/accounts/backends.py (Diff revision 2) We should include the exception in this log entry.
TE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+75 -1) |
-
Tool: Pyflakes Processed Files: reviewboard/accounts/backends.py reviewboard/accounts/forms/auth.py setup.py reviewboard/admin/management/sites.py reviewboard/admin/siteconfig.py Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/backends.py reviewboard/accounts/forms/auth.py setup.py reviewboard/admin/management/sites.py reviewboard/admin/siteconfig.py -
-
-
Tool: Pyflakes Processed Files: reviewboard/accounts/backends.py reviewboard/accounts/forms/auth.py setup.py reviewboard/admin/management/sites.py reviewboard/admin/siteconfig.py Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/backends.py reviewboard/accounts/forms/auth.py setup.py reviewboard/admin/management/sites.py reviewboard/admin/siteconfig.py