Repository check for RBTools command "post"

Review Request #6798 — Created Jan. 17, 2015 and discarded

tienv
RBTools
master
rbtools, students
When submitting to repository with RBTools, if requested repository could not be found by the Review Board server, raise an Error.


Description From Last Updated

Please revert this changed line.

daviddavid

You don't need parentheses around the conditional statement.

daviddavid

This should be in sentence casing, and should ideally be fleshed out a bit more. If you were to see …

chipx86chipx86

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/commands/post.py (Diff revision 1)
     
     

    Please revert this changed line.

  3. rbtools/commands/post.py (Diff revision 1)
     
     

    You don't need parentheses around the conditional statement.

  4. 
      
chipx86
  1. Make sure you read my recommendations in #students about drafting summaries, descriptions, and testing, and look at some of the examples.

  2. rbtools/commands/post.py (Diff revision 1)
     
     

    This should be in sentence casing, and should ideally be fleshed out a bit more. If you were to see this from a program you just started using, you'd probably want it to be more explicit about what went wrong.

    It's also helpful to have errors appear more naturally-written, like you were telling it to someone.

  3. 
      
TI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. rbtools/commands/post.py (Diff revision 2)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  3. 
      
mike_conley
  1. Hey tienv, any update to this one?

  2. 
      
david
  1. This should have a bug number assigned. Please also address Review Bot's comment.

  2. 
      
TI
Review request changed

Status: Discarded

Loading...