Provide a good error when trying to POST a duplicate repository.
Review Request #6795 — Created Jan. 17, 2015 and submitted
Our validation when using the repository resource to create new repositories
handled the case where an individual field in the model didn't validate, but
didn't handle the case of conflicting names.This adds a new API error for when the repository already exists, and adds a
test to verify that it's being used.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
This needs to go in the list of errors in the decorator. Since we're changing the expected error condition, the … |
 chipx86
|
-
-
reviewboard/webapi/resources/repository.py (Diff revision 1) This needs to go in the list of errors in the decorator.
Since we're changing the expected error condition, the docstring should also be updated to say that starting in 2.0.13, it returns this, and previously it returned the other thing.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+22 -6) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/repository.py reviewboard/webapi/errors.py reviewboard/webapi/tests/test_repository.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/repository.py reviewboard/webapi/errors.py reviewboard/webapi/tests/test_repository.py
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/repository.py reviewboard/webapi/errors.py reviewboard/webapi/tests/test_repository.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/repository.py reviewboard/webapi/errors.py reviewboard/webapi/tests/test_repository.py