Summary

Provide a good error when trying to POST a duplicate repository.

Review Request #6795 — Created Jan. 17, 2015 and submitted Jan. 17, 2015, 1:05 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3625

Depends On

Commit

8df907d...

Reviewers

Groups

reviewboard

People

Description

Our validation when using the repository resource to create new repositories
handled the case where an individual field in the model didn't validate, but
didn't handle the case of conflicting names.

This adds a new API error for when the repository already exists, and adds a
test to verify that it's being used.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This needs to go in the list of errors in the decorator. Since we're changing the expected error condition, the …	chipx86	Jan. 17, 2015, 10:12 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_repository.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_repository.py

reviewboard/webapi/resources/repository.py (Diff revision 1)

The issue has been resolved. Show all issues

This needs to go in the list of errors in the decorator.

Since we're changing the expected error condition, the docstring should also be updated to say that starting in 2.0.13, it returns this, and previously it returned the other thing.

david Jan. 17, 2015, 10:12 a.m.

I don't think we need to change the docstring because previously it returned a 500 error with a traceback.

chipx86 Jan. 17, 2015, 12:35 p.m.
```
Ah, yes, this is an improvement then :)
```

Commit:

57f104e63f9a94f1b12c430bded04a68aad77ef4

8df907dbe01773eb5cbea21c3567fab4f5db2e6a

Diff:

Revision 2 (+22 -6)

Show changes

	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/repository.py
	reviewboard/webapi/tests/test_repository.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_repository.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_repository.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (47cd8fa)