Fixed rbt patch to work with $EDITOR that has spaces

 






 

 


  Review Request #6784
  —
  Created Jan. 16, 2015 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  tbelaire
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 









 
 

  dc34986...
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
Before, it was looking for the executable with exactly

the name in $EDITOR, spaces and all, and failing to find it.

Now it splits it up by spaces before calling the shell.


Fixes issue: Issue 3652: rbt patch throws "OSError: [Errno 2] No such file or directory" if EDITOR contains flags

 








  


 
 

  
From the issue.


EDITOR="vim -X" python -c "from rbtools.utils.console import edit_text; edit_text('')"



Before, it crashed, now it does not.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/utils/console.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...