Summary

Fixed rbt patch to work with $EDITOR that has spaces

Review Request #6784 — Created Jan. 16, 2015 and submitted Jan. 16, 2015, 2:32 p.m.

Information

Owner

tbelaire

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

dc34986...

Reviewers

Groups

rbtools

People

Description

Before, it was looking for the executable with exactly
the name in $EDITOR, spaces and all, and failing to find it.
Now it splits it up by spaces before calling the shell.

Fixes issue: Issue 3652: rbt patch throws "OSError: [Errno 2] No such file or directory" if EDITOR contains flags

Testing Done

From the issue.
EDITOR="vim -X" python -c "from rbtools.utils.console import edit_text; edit_text('')"

Before, it crashed, now it does not.

Issues

Description	From	Last Updated
There's a right square bracket with no left square bracket.	VT VTL-Developer	Jan. 16, 2015, 11:14 a.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/console.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/console.py

Ship it!

```
This looks good to me. Thanks!
```

Ship it!

```
Ship It!
```

Can .split(' ') be replaced with .split() to do the same functionality?

tbelaire Jan. 16, 2015, 11:17 a.m.

Sure, it looks like it's actually a better algorithm altogether when you specify None or no argument.
If there's a run of multiple spaces your method will work better.

rbtools/utils/console.py (Diff revision 1)

Show all issues

There's a right square bracket with no left square bracket.

Change Summary:

split called with no arguments now.

Commit:

-	96df3233631775a3fea89c8fa3129b35845095d2
+	dc34986b41e3084a07937fee37f2f54c12eb4734

Diff:

Revision 2 (+1 -1)

Show changes

rbtools/utils/console.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/console.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/console.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (a38ca9b)