Fix rendering change descriptions without raw insert/delete counts.

Review Request #6778 — Created Jan. 15, 2015 and submitted

Information

Review Board
release-2.0.x
7cb8931...

Reviewers

When rendering a change entry for a diff, the code attempts to get the
total raw insert/delete line counts across all FileDiffs. If there are
no FileDiffs for some reason, then this would end up crashing.

We're now more careful to not assume these counts exist, and to use 0 as
the value in this case.

Tested with faking the return value for the function.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (3383d81)
Loading...