convert xml.dom.minidom.Attr value to int in reviewboard.reviews.markdown_utils:iter_markdown_lines
Review Request #6764 — Created Jan. 12, 2015 and discarded
fixes issue 3715
I wrote unit tests and ran
python reviewboard/manage.py test
:<snip> When an ordered list does not have a start attr, do not treat it as a xml.dom.minidom.Attr ... ok Raise an exception for ordered lists with non-int values for their start attribute ... ok When reading the start attr for lists, convert the value to an int ... ok
Description | From | Last Updated |
---|---|---|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (104 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (96 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot | |
local variable 'markdown_html' is assigned to but never used |
reviewbot | |
undefined name 'markdown' |
reviewbot | |
local variable 'markdown_html' is assigned to but never used |
reviewbot | |
undefined name 'markdown' |
reviewbot | |
local variable 'markdown_html' is assigned to but never used |
reviewbot | |
undefined name 'markdown' |
reviewbot | |
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+31) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+31) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py Tool: Pyflakes Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py
-
reviewboard/reviews/tests.py (Diff revision 3) local variable 'markdown_html' is assigned to but never used
-
-
reviewboard/reviews/tests.py (Diff revision 3) local variable 'markdown_html' is assigned to but never used
-
-
reviewboard/reviews/tests.py (Diff revision 3) local variable 'markdown_html' is assigned to but never used
-
Change Summary:
finish variable rename
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+31) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py
-
Change Summary:
make a line in tests shorter to adhere to pyflake settings
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+32) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/markdown_utils.py reviewboard/reviews/tests.py