Summary

convert xml.dom.minidom.Attr value to int in reviewboard.reviews.markdown_utils:iter_markdown_lines

Review Request #6764 — Created Jan. 12, 2015 and discarded Jan. 13, 2015, 2 p.m.

Information

Owner

dgholz

Repository

Review Board

Branch

master

Bugs

3715

Depends On

Reviewers

Groups

reviewboard

People

Description

fixes issue 3715

Testing Done

I wrote unit tests and ran python reviewboard/manage.py test:

<snip>
When an ordered list does not have a start attr, do not treat it as a xml.dom.minidom.Attr ... ok
Raise an exception for ordered lists with non-int values for their start attribute ... ok
When reading the start attr for lists, convert the value to an int ... ok

Issues

Description	From	Last Updated
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Jan. 12, 2015, 11:36 p.m.
Col: 80 E501 line too long (104 > 79 characters)	reviewbot	Jan. 12, 2015, 11:36 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Jan. 12, 2015, 11:36 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Jan. 12, 2015, 11:36 p.m.
local variable 'markdown_html' is assigned to but never used	reviewbot	Jan. 13, 2015, 7:27 a.m.
undefined name 'markdown'	reviewbot	Jan. 13, 2015, 7:27 a.m.
local variable 'markdown_html' is assigned to but never used	reviewbot	Jan. 13, 2015, 7:27 a.m.
undefined name 'markdown'	reviewbot	Jan. 13, 2015, 7:27 a.m.
local variable 'markdown_html' is assigned to but never used	reviewbot	Jan. 13, 2015, 7:27 a.m.
undefined name 'markdown'	reviewbot	Jan. 13, 2015, 7:27 a.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Jan. 13, 2015, 7:32 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py

reviewboard/reviews/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (104 > 79 characters)
```
reviewboard/reviews/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
reviewboard/reviews/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```

Commit:

562e486d071bb36cc193e53380a164c6d3fb0e23

a45d3dda0c4de6a2e648f83b6a8150885a336bd2

Diff:

Revision 2 (+31)

Show changes

	reviewboard/reviews/markdown_utils.py
	reviewboard/reviews/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py

Commit:

a45d3dda0c4de6a2e648f83b6a8150885a336bd2

1f1a989e49b99557564c181b25cf5fd4c9c1f57a

Diff:

Revision 3 (+31)

Show changes

	reviewboard/reviews/markdown_utils.py
	reviewboard/reviews/tests.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py

reviewboard/reviews/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 local variable 'markdown_html' is assigned to but never used
```
reviewboard/reviews/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'markdown'
```
reviewboard/reviews/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 local variable 'markdown_html' is assigned to but never used
```
reviewboard/reviews/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'markdown'
```
reviewboard/reviews/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 local variable 'markdown_html' is assigned to but never used
```
reviewboard/reviews/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'markdown'
```

Change Summary:

finish variable rename

Commit:

1f1a989e49b99557564c181b25cf5fd4c9c1f57a

14d46056d1446ce952624ce0d5777fb930fece65

Diff:

Revision 4 (+31)

Show changes

	reviewboard/reviews/markdown_utils.py
	reviewboard/reviews/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py

reviewboard/reviews/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

Change Summary:

make a line in tests shorter to adhere to pyflake settings

Commit:

14d46056d1446ce952624ce0d5777fb930fece65

a9d32f6ee657da841289479aae4c3537481a5975

Diff:

Revision 5 (+32)

Show changes

	reviewboard/reviews/markdown_utils.py
	reviewboard/reviews/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py

Thanks for the change. I'd actually just finished a very similar change, and landed that one since I'm more familiar with it.

Status:: Discarded