Run post-commit SVN diffs through convert_to_unicode.
Review Request #6763 — Created Jan. 12, 2015 and submitted — Latest diff uploaded
We were blindly interpreting the results of the lower-level SVN libraries' diff
commands as utf-8. This worked until now, but it failed for a certain
iso-8859-1 character. This change switches us to use our fancy
convert_to_unicode method, which will try utf-8, anything that's configured for
the repository, and iso-8859-1.
Ran unit tests.
Diff Revision 1
This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.
orig
1
2
reviewboard/scmtools/svn/__init__.py |
---|
reviewboard/scmtools/svn/base.py |
---|
reviewboard/scmtools/svn/pysvn.py |
---|
reviewboard/scmtools/svn/subvertpy.py |
---|