Run post-commit SVN diffs through convert_to_unicode.
Review Request #6763 — Created Jan. 12, 2015 and submitted
We were blindly interpreting the results of the lower-level SVN libraries' diff
commands as utf-8. This worked until now, but it failed for a certain
iso-8859-1 character. This change switches us to use our fancy
convert_to_unicode method, which will try utf-8, anything that's configured for
the repository, and iso-8859-1.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Wouldn't it be better to let the implementations be dumb and just do the conversion here? |
 chipx86
|
-
-
reviewboard/scmtools/svn/__init__.py (Diff revision 1) Wouldn't it be better to let the implementations be dumb and just do the conversion here?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+6 -3) |
Tool: Pyflakes Processed Files: reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/svn/base.py Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/svn/base.py