Fix handling of 'start' parameter for markdown lists.
Review Request #6761 — Created Jan. 12, 2015 and submitted
If a list starts at something other than '1', we'd fail, treating a Node.Attr
instance as if it were an int. This change fixes the types to actually fetch
the correct value.
- Set up a markdown list starting at '2' and saw that it no longer failed.
- Ran unit tests.
-
Can we add unit tests for the different conditions here?
-
reviewboard/reviews/markdown_utils.py (Diff revision 1) Can
start
beNone
? Wouldn't it default to1
?The
if start
will probably do the wrong thing if trying to begin a list at 0.
Change Summary:
Make requested changes.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+21 -1) |