Summary

Fix handling of 'start' parameter for markdown lists.

Review Request #6761 — Created Jan. 12, 2015 and submitted Jan. 13, 2015, 1:58 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3715

Depends On

Commit

4ac55ca...

Reviewers

Groups

reviewboard

People

Description

If a list starts at something other than '1', we'd fail, treating a Node.Attr
instance as if it were an int. This change fixes the types to actually fetch
the correct value.

Testing Done


Set up a markdown list starting at '2' and saw that it no longer failed.
Ran unit tests.

Issues

Description	From	Last Updated
Can start be None? Wouldn't it default to 1? The if start will probably do the wrong thing if trying …	chipx86	Jan. 12, 2015, 4:31 p.m.
"Markdown"	chipx86	Jan. 13, 2015, 1:57 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py

Can we add unit tests for the different conditions here?

reviewboard/reviews/markdown_utils.py (Diff revision 1)

The issue has been resolved. Show all issues

Can start be None? Wouldn't it default to 1?

The if start will probably do the wrong thing if trying to begin a list at 0.

david Jan. 12, 2015, 4:43 p.m.

I flubbed the diff a little bit here. It was wound up with another change and I forgot to remove the default.

Change Summary:

Make requested changes.

Commit:

e1d4da4bbe0c19bd534ef90eeaf22f4089435781

4ac55ca3fa73d72f5ea52be0afc628050d38722c

Diff:

Revision 2 (+21 -1)

Show changes

	reviewboard/reviews/markdown_utils.py
	reviewboard/reviews/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py
    reviewboard/reviews/tests.py

Ship it!

reviewboard/reviews/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"Markdown"
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (4f11579)