Fix KeyError when saving repository form
Review Request #6746 — Created Jan. 7, 2015 and submitted
A KeyError was raised when certain hosting services (like GitHub) did not contain 'default' as a plan. To fix this, check that 'default' exists in the bug_tracker_forms dictionary before running the remaining validations.
Successfully ran existing scmtools tests. KeyError was no longer raised when a new repository was created.
| Description | From | Last Updated |
|---|---|---|
|
To reduce the complexity of the code, try: field = self.bug_tracker_forms[bug_tracker_type].get('default') if field: ... |
 chipx86
|
-
Can you add a bit of info to the summary and description? Just something that mentions not all hosts support default field values.
-
The code looks OK, but your summary and description need work. The summary should be something like "Fix KeyError when saving repository form", and the description should explain what the bug was and how your change fixes it.
CR
Summary: |
|
||||||
|---|---|---|---|---|---|---|---|
Description: |
|
-
-
reviewboard/scmtools/forms.py (Diff revision 1) To reduce the complexity of the code, try:
field = self.bug_tracker_forms[bug_tracker_type].get('default') if field: ...
CR
Change Summary:
Simplified if statement
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+5 -4) |
-
Tool: Pyflakes Processed Files: reviewboard/scmtools/forms.py Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/forms.py
Tool: Pyflakes Processed Files: reviewboard/scmtools/forms.py Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/forms.py