Add an option to delete branches after landing them.
Review Request #6727 — Created Jan. 2, 2015 and submitted
This introduces --delete-branch and --no-delete-branch options for
handling whether a branch should be deleted after successfully being
landed.By default, a branch is deleted, but LAND_DELETE_BRANCH can be set
in .reviewboardrc to change this behavior.
Tested landing a branch without --delete-branch. Saw that the branch was
deleted after landing.Tested landing with --no-delete-branch. Saw that the branch was not deleted
after landing.Changed the setting in .reviewboardrc and tested. Saw that the branch was not
deleted.
Review request changed
- Change Summary:
-
Added documentation.
- Commit:
-
9746a70af0d79fc4a0d63f84f5406c34a05c536c8e8b8901b70431255e2ff2c4ca85ee9c7684c2a8
-
Tool: Pyflakes Processed Files: rbtools/commands/land.py rbtools/clients/__init__.py rbtools/clients/git.py Ignored Files: docs/rbtools/rbt/commands/land.rst Tool: PEP8 Style Checker Processed Files: rbtools/commands/land.py rbtools/clients/__init__.py rbtools/clients/git.py Ignored Files: docs/rbtools/rbt/commands/land.rst
Review request changed
- Change Summary:
-
Updated the description and testing to account for the new defaults. I changed defaults in the diff before publishing before, but forgot to update the fields here.
- Description:
-
This introduces --delete-branch and --no-delete-branch options for
handling whether a branch should be deleted after successfully being landed. ~ By default, a branch is not deleted, but LAND_DELETE_BRANCH can be set
~ By default, a branch is deleted, but LAND_DELETE_BRANCH can be set
in .reviewboardrc to change this behavior. - Testing Done:
-
~ Tested landing a branch with --delete-branch. Saw that the branch was
~ Tested landing a branch without --delete-branch. Saw that the branch was
deleted after landing. + + Tested landing with --no-delete-branch. Saw that the branch was not deleted
+ after landing. + + Changed the setting in .reviewboardrc and tested. Saw that the branch was not
+ deleted.
Tool: PEP8 Style Checker Processed Files: rbtools/commands/land.py rbtools/clients/__init__.py rbtools/clients/git.py Tool: Pyflakes Processed Files: rbtools/commands/land.py rbtools/clients/__init__.py rbtools/clients/git.py