Fix issues guessing review requests in rbt land.

Review Request #6726 — Created Jan. 2, 2015 and submitted

Information

RBTools
master
e62e065...

Reviewers

rbt land wasn't including the specified branch name as part of the list
of arguments that get passed to get_revisions(). This caused the review
request guessing code to look at HEAD, instead of the specified branch.

That bug exposed another problem, which is that the review request
guessing code didn't pre-define the summary and description, leading to
an error later on if a summary or description was not found. We now
properly bail in this case.

Properly landed a change from a different branch than HEAD.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/land.py
        rbtools/utils/review_request.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/commands/land.py
        rbtools/utils/review_request.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (2de4d9a)
Loading...