Summary:

Use Option's config_key for customizable dest branches in rbt land.

Review Request #6717 — Created Jan. 1, 2015 and submitted Jan. 2, 2015, 12:58 a.m.

Information
Owner:	chipx86
Repository:	RBTools
Branch:	master
Bugs:
Depends On:
Commit:	ef12cf3...
Reviewers
Groups:	rbtools
People:

Description

rbt land had some custom code for allowing the destination branch to be
specified in .reviewboardrc, but it was just re-implementing the logic
that already lives in Option. Now we use Option's native support for
this, simplifying rbt land.

Testing Done

Tested with just a command line argument.

Tested with just a config setting in .reviewboardrc.

Tested without any defaults.

For each, I altered the code to print the value and compared to my expected value.

Issues

Description	From	Last Updated
undefined name 'destination_branch'	reviewbot	Jan. 1, 2015, 11:32 a.m.
undefined name 'destination_branch'	reviewbot	Jan. 1, 2015, 11:32 a.m.
undefined name 'destination_branch'	reviewbot	Jan. 1, 2015, 11:32 a.m.
undefined name 'destination_branch'	reviewbot	Jan. 1, 2015, 11:32 a.m.
undefined name 'confirm'	reviewbot	Jan. 1, 2015, 11:31 a.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/land.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/land.py

rbtools/commands/land.py (Diff revision 1)
Show all issues
```
 undefined name 'destination_branch'
```
rbtools/commands/land.py (Diff revision 1)
Show all issues
```
 undefined name 'destination_branch'
```
rbtools/commands/land.py (Diff revision 1)
Show all issues
```
 undefined name 'destination_branch'
```
rbtools/commands/land.py (Diff revision 1)
Show all issues
```
 undefined name 'destination_branch'
```
rbtools/commands/land.py (Diff revision 1)
Show all issues
```
 undefined name 'confirm'
```

Change Summary:

Added back a missing variable.

Commit:

-	46929de67d1e4be1f1bf595ceeee0e6bee8664fa
+	ef12cf3f8f673cdfc1530a7fd50c70b07d207362

Diff:

Revision 2 (+4 -5)

Show changes

rbtools/commands/land.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/land.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/land.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (5cd186d)

rbtools/commands/land.py (Diff revision 1)

rbtools/commands/land.py (Diff revision 1)

rbtools/commands/land.py (Diff revision 1)

rbtools/commands/land.py (Diff revision 1)