• 
      

    Use Option's config_key for customizable dest branches in rbt land.

    Review Request #6717 — Created Jan. 1, 2015 and submitted

    Information

    RBTools
    master
    ef12cf3...

    Reviewers

    rbt land had some custom code for allowing the destination branch to be
    specified in .reviewboardrc, but it was just re-implementing the logic
    that already lives in Option. Now we use Option's native support for
    this, simplifying rbt land.

    Tested with just a command line argument.

    Tested with just a config setting in .reviewboardrc.

    Tested without any defaults.

    For each, I altered the code to print the value and compared to my expected value.

    Description From Last Updated

    undefined name 'destination_branch'

    reviewbot reviewbot

    undefined name 'destination_branch'

    reviewbot reviewbot

    undefined name 'destination_branch'

    reviewbot reviewbot

    undefined name 'destination_branch'

    reviewbot reviewbot

    undefined name 'confirm'

    reviewbot reviewbot
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/land.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          rbtools/commands/land.py
      
      
    2. rbtools/commands/land.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'destination_branch'
      
    3. rbtools/commands/land.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'destination_branch'
      
    4. rbtools/commands/land.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'destination_branch'
      
    5. rbtools/commands/land.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'destination_branch'
      
    6. rbtools/commands/land.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'confirm'
      
    7. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/commands/land.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/land.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (5cd186d)