Clean up perforce connection to use a context manager.

Review Request #6707 — Created Dec. 19, 2014 and submitted

Information

Review Board
release-2.0.x
57e3661...

Reviewers

This change makes a long-awaited cleanup to the perforce connection logic,
using a context manager rather than an ugly except block. I've also moved the
import of P4Exception to hopefully work better across a range of systems.

Ran unit tests.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/perforce.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (724bc6f)
Loading...