Fixed up sample code for the extension hooks.

Review Request #6705 — Created Dec. 18, 2014 and submitted

justy777
Review Board
master
86a373b...
reviewboard

Issues were found in the example code while going through extension hooks documentation. If those pieces of example code were ever run they would cause an error.

Now, all issues have been fixed, and the example code is valid python.

Ran example code from extension hooks documentation.

Description From Last Updated

Revert this line.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        docs/manual/extending/extensions/hooks/file-attachment-thumbnail-hook.rst
        docs/manual/extending/extensions/review-ui.rst
        docs/manual/extending/extensions/hooks/review-request-fields-hook.rst
        docs/manual/extending/extensions/hooks/auth-backend-hook.rst
        docs/manual/extending/extensions/hooks/webapi-capabilities-hook.rst
        docs/manual/extending/extensions/hooks/hosting-service-hook.rst
        docs/manual/extending/extensions/hooks/action-hooks.rst
        docs/manual/extending/extensions/hooks/account-pages-hook.rst
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        docs/manual/extending/extensions/hooks/file-attachment-thumbnail-hook.rst
        docs/manual/extending/extensions/review-ui.rst
        docs/manual/extending/extensions/hooks/review-request-fields-hook.rst
        docs/manual/extending/extensions/hooks/auth-backend-hook.rst
        docs/manual/extending/extensions/hooks/webapi-capabilities-hook.rst
        docs/manual/extending/extensions/hooks/hosting-service-hook.rst
        docs/manual/extending/extensions/hooks/action-hooks.rst
        docs/manual/extending/extensions/hooks/account-pages-hook.rst
    
    
  2. 
      
david
  1. 
      
  2. Revert this line.

  3. 
      
justy777
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        docs/manual/extending/extensions/hooks/file-attachment-thumbnail-hook.rst
        docs/manual/extending/extensions/review-ui.rst
        docs/manual/extending/extensions/hooks/review-request-fields-hook.rst
        docs/manual/extending/extensions/hooks/auth-backend-hook.rst
        docs/manual/extending/extensions/hooks/webapi-capabilities-hook.rst
        docs/manual/extending/extensions/hooks/hosting-service-hook.rst
        docs/manual/extending/extensions/hooks/action-hooks.rst
        docs/manual/extending/extensions/hooks/account-pages-hook.rst
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        docs/manual/extending/extensions/hooks/file-attachment-thumbnail-hook.rst
        docs/manual/extending/extensions/review-ui.rst
        docs/manual/extending/extensions/hooks/review-request-fields-hook.rst
        docs/manual/extending/extensions/hooks/auth-backend-hook.rst
        docs/manual/extending/extensions/hooks/webapi-capabilities-hook.rst
        docs/manual/extending/extensions/hooks/hosting-service-hook.rst
        docs/manual/extending/extensions/hooks/action-hooks.rst
        docs/manual/extending/extensions/hooks/account-pages-hook.rst
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
justy777
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (9320259)
Loading...