Summary

Fix losing the commit summary when using rbt stamp.

Review Request #6701 — Created Dec. 17, 2014 and submitted Dec. 31, 2014, 5:26 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

7dc1330...

Reviewers

Groups

rbtools

People

Description

When rebuilding the commit message, rbt stamp was losing the summary.
This was due to the code only factoring in the description for the new
message.

We now build upon the raw commit message, rather than a parsed message.
We also don't try to stamp the commit if it's already been stamped.

Testing Done

Stamped a commit and didn't lose the summary.

Tried stamping again and saw a message saying it was already stamped.

Tool: Pyflakes
Processed Files:
    rbtools/commands/stamp.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/stamp.py

Change Summary:

Failed to actually post the latest update before publishing..

Description:

		When rebuilding the commit message, rbt stamp was losing the summary.
		This was due to the code only factoring in the description for the new
~		message. We now include this when building the commit message, if the
~		description doesn't already include it.
	~	message.
	~
	+	We now build upon the raw commit message, rather than a parsed message.
	+	We also don't try to stamp the commit if it's already been stamped.

Commit:

-	5c345be3bcc6c0130e3c451c294fbbc9d13e8075
+	7dc1330b2ce0ca3d69e7b277c78c660bc07e26eb

Diff:

Revision 2 (+17 -8)

Show changes

	rbtools/commands/stamp.py
	rbtools/utils/review_request.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/review_request.py
    rbtools/commands/stamp.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/review_request.py
    rbtools/commands/stamp.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f34400e)