Summary

Do unicode migration for rbtools/api/

Review Request #6686 — Created Dec. 9, 2014 and submitted Dec. 11, 2014, 5:45 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

5317e31...

Reviewers

Groups

rbtools

People

Description

This change updates the code in the rbtools/api/ directory to have a correct
separation of unicode vs bytes, and use unicode literals everywhere.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Dec. 9, 2014, 3:24 p.m.
Col: 21 E128 continuation line under-indented for visual indent	reviewbot	Dec. 9, 2014, 3:24 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Dec. 9, 2014, 3:24 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	Dec. 9, 2014, 3:25 p.m.
This looks kind of funky. Can we not use a byte string and feed in key.encode('utf-8'), like: content.write(b'Content-Disposition: formd-ata; name="%s"' …	chipx86	Dec. 10, 2014, 2:38 p.m.
Blank line between these.	chipx86	Dec. 10, 2014, 2:36 p.m.
Blank line.	chipx86	Dec. 10, 2014, 2:37 p.m.
Blank line.	chipx86	Dec. 10, 2014, 2:37 p.m.
We should probably update these (and any above) to use formatting strings instead of concatenation, since the latter is slower.	chipx86	Dec. 10, 2014, 2:42 p.m.
Same question as above.	chipx86	Dec. 10, 2014, 2:41 p.m.
""" on the next line.	chipx86	Dec. 10, 2014, 2:42 p.m.
This should probably be using formatting strings to.	chipx86	Dec. 10, 2014, 2:42 p.m.
Is this needed for regexes? I'd expect r.	chipx86	Dec. 10, 2014, 2:43 p.m.
Same here. We should also move this out and compile it so we don't have eto do that each time …	chipx86	Dec. 10, 2014, 2:44 p.m.
repr doesn't seem like the right thing here, at least conceptually. What are we using it for?	chipx86	Dec. 11, 2014, 5:43 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py

rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 E128 continuation line under-indented for visual indent
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/api/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```

Commit:

414e034fbc435a27110142afa26ca1c6fd034341

cd5b8c712cf6a900eb337c06da5fd19fb2ae52e0

Diff:

Revision 2 (+89 -39)

Show changes

	rbtools/api/capabilities.py
	rbtools/api/client.py
	rbtools/api/decode.py
	rbtools/api/decorators.py
	rbtools/api/errors.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/resource.py
	2 more

Tool: Pyflakes
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py

rbtools/api/request.py (Diff revision 2)

The issue has been dropped. Show all issues

This looks kind of funky. Can we not use a byte string and feed in key.encode('utf-8'), like:

content.write(b'Content-Disposition: formd-ata; name="%s"'
              % key.encode('utf-8'))

david

Dec. 10, 2014, 2:59 p.m.

The 'bytes' type in Python 3.x doesn't have a % operator, and won't until 3.5. I'll try wrapping this differently.

rbtools/api/request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line between these.
```
rbtools/api/request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line.
```
rbtools/api/request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line.
```

rbtools/api/request.py (Diff revision 2)

The issue has been dropped. Show all issues

We should probably update these (and any above) to use formatting strings instead of concatenation, since the latter is slower.

david

Dec. 10, 2014, 2:59 p.m.

Between the decode, format, and re-encode, I think it's probably a wash in terms of speed, and this only happens once per API request.

rbtools/api/request.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Same question as above.
```
rbtools/api/request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
""" on the next line.
```
rbtools/api/request.py (Diff revision 2)
The issue has been dropped. Show all issues
```
This should probably be using formatting strings to.
```

rbtools/api/tests.py (Diff revision 2)

The issue has been dropped. Show all issues

Is this needed for regexes? I'd expect r.

david

Dec. 10, 2014, 2:59 p.m.

It's needed if you run the regex on bytes types. It's not using the r prefix because there are no characters.

rbtools/api/tests.py (Diff revision 2)

The issue has been resolved. Show all issues

Same here.

We should also move this out and compile it so we don't have eto do that each time in this loop.

Commit:

cd5b8c712cf6a900eb337c06da5fd19fb2ae52e0

cf7944675cbd0a286fdcde4ce042e3af61924fbb

Diff:

Revision 3 (+95 -39)

Show changes

	rbtools/api/capabilities.py
	rbtools/api/client.py
	rbtools/api/decode.py
	rbtools/api/decorators.py
	rbtools/api/errors.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/resource.py
	2 more

Tool: Pyflakes
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py

rbtools/api/request.py (Diff revision 3)

The issue has been resolved. Show all issues

repr doesn't seem like the right thing here, at least conceptually. What are we using it for?

Commit:

cf7944675cbd0a286fdcde4ce042e3af61924fbb

5317e315b6582eea6462a3dadf1aa5be40e1ddbf

Diff:

Revision 4 (+95 -39)

Show changes

	rbtools/api/capabilities.py
	rbtools/api/client.py
	rbtools/api/decode.py
	rbtools/api/decorators.py
	rbtools/api/errors.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/resource.py
	2 more

Tool: Pyflakes
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/client.py
    rbtools/api/resource.py
    rbtools/api/decorators.py
    rbtools/api/factory.py
    rbtools/api/decode.py
    rbtools/api/capabilities.py
    rbtools/api/tests.py
    rbtools/api/request.py
    rbtools/api/errors.py
    rbtools/api/utils.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (b2d562a)