Summary

Create new sites in a default path

Review Request #6682 — Created Dec. 8, 2014 and submitted Jan. 8, 2015, 4:48 p.m.

Information

Owner

sgallagh

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

e8586ea...

Reviewers

Groups

reviewboard

People

chipx86

Description

This lays the groundwork for better support of SELinux on platforms
that support it. SELinux rules are based in large part on
filesystem location. By installing sites into a default path, we
can create the SELinux rules on those standard paths.

This patch also moves a few global variables into a new platform.py
file. This is so that packagers for Linux distributions have an
easy place to identify things like filesystem paths that commonly
need to be modified to meet the system's packaging guidelines.

NOTE: This patch changes the current behavior in one significant
place: rb-site can no longer reference relative paths for the site
directory. Any site input that is not absolute will be assumed to
be relative to the default site path instead of the current
directory.

Testing Done

I created a site using 'rb-site install rb.example.com', which succeeded. I then also tested 'rb-site upgrade rb.example.com', which also succeeded.

Issues

Description	From	Last Updated
Col: 34 E126 continuation line over-indented for hanging indent	reviewbot	Dec. 8, 2014, 6:03 a.m.
You should be using __future__.unicode_literals	brennie	Dec. 11, 2014, 6:16 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py

reviewboard/cmdline/rbsite.py (Diff revision 1)

Show all issues

Col: 34
 E126 continuation line over-indented for hanging indent

reviewboard/cmdline/rbsite.py (Diff revision 1)

I'll change this if desired, but I'd argue that PEP8 is wrong here; the full indentation makes it more readable.

chipx86 Dec. 8, 2014, 11:54 a.m.

We're using parens for multi-line imports, which makes Review Bot/pep8 tool happier. For instance:

from reviewboard.platform import (SITELIST_FILE_UNIX,
                                  ...)

Change Summary:

Switched the multi-line import to make PEP8 happy.

Commit:

-	e331add7b4a7bfb8701578bb81e58650199e789a
+	87cf15b9596beabb46d4f9fae801fd512ea7c2e2

Diff:

Revision 2 (+37 -6)

Show changes

	reviewboard/platform.py
	reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py

reviewboard/platform.py (Diff revision 2)

Show all issues

You should be using __future__.unicode_literals

brennie Dec. 10, 2014, 1:22 p.m.

Since this was a bit unclear, what I meant was that you should have
from __future__ import unicode_literals

at the top of the file

Change Summary:

Changed the relative path detection to use the platform-agnostic os.path.isabs() rather than checking for a leading slash

Description:

		This lays the groundwork for better support of SELinux on platforms
		that support it. SELinux rules are based in large part on
		filesystem location. By installing sites into a default path, we
		can create the SELinux rules on those standard paths.

		This patch also moves a few global variables into a new platform.py
		file. This is so that packagers for Linux distributions have an
		easy place to identify things like filesystem paths that commonly
		need to be modified to meet the system's packaging guidelines.

		NOTE: This patch changes the current behavior in one significant
		place: rb-site can no longer reference relative paths for the site
~		directory. Any site input that does not have a leading slash will
~		be assumed to be relative to the default site path instead of the
~		current directory.
	~	directory. Any site input that is not absolute will be assumed to
	~	be relative to the default site path instead of the current
	~	directory.

Commit:

-	87cf15b9596beabb46d4f9fae801fd512ea7c2e2
+	f1acc7a29fe57ba56c65fdc05f0b4ee5fe364d12

Diff:

Revision 3 (+37 -6)

Show changes

	reviewboard/platform.py
	reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py

Change Summary:

Added unicode_literals to platform.py

Commit:

-	f1acc7a29fe57ba56c65fdc05f0b4ee5fe364d12
+	e8586ea8b4da0bc6846fff80c7d79407fe2b8315

Diff:

Revision 4 (+38 -6)

Show changes

	reviewboard/platform.py
	reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/platform.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (d095085)