Summary

Make a bunch of smaller 2to3 related refactors.

Review Request #6681 — Created Dec. 8, 2014 and submitted Dec. 8, 2014, 7:18 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

0b7e72e...

Reviewers

Groups

rbtools

People

Description

This change makes a bunch of small updates to bring code into compliance with
both Python 2.x and 3.x.

Testing Done


Ran unit tests.
Posted some changes.

Issues

Description	From	Last Updated
We can probably improve on the old and new design by using itertools.chain(...) on these.	chipx86	Dec. 8, 2014, 6:51 a.m.
Minor thing, but can we put the generator lines on a new line, like: num_files_in_diffs = len([ line ... ]) …	chipx86	Dec. 8, 2014, 6:51 a.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Dec. 8, 2014, 6:35 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/resource.py
    rbtools/clients/tests.py
    rbtools/commands/setup_repo.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/utils/filesystem.py
    rbtools/utils/console.py
    rbtools/utils/users.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/resource.py
    rbtools/clients/tests.py
    rbtools/commands/setup_repo.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/utils/filesystem.py
    rbtools/utils/console.py
    rbtools/utils/users.py

rbtools/commands/setup_repo.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

rbtools/clients/clearcase.py (Diff revision 1)

The issue has been resolved. Show all issues

We can probably improve on the old and new design by using itertools.chain(...) on these.

rbtools/clients/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Minor thing, but can we put the generator lines on a new line, like:

num_files_in_diffs = len([
    line
    ...
])

Only reason Review Bot isn't complaining is because the lines happen to be a multiple of 4.

Commit:

1295081bdd698714350a8224128988a2329a5216

0b7e72e55e0ec8245c9296f4b9949e528c47d8c5

Diff:

Revision 2 (+41 -19)

Show changes

	rbtools/api/resource.py
	rbtools/clients/clearcase.py
	rbtools/clients/plastic.py
	rbtools/clients/tests.py
	rbtools/commands/__init__.py
	rbtools/commands/main.py
	rbtools/commands/setup_repo.py
	rbtools/utils/console.py
	2 more

Tool: Pyflakes
Processed Files:
    rbtools/api/resource.py
    rbtools/clients/tests.py
    rbtools/commands/setup_repo.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/utils/filesystem.py
    rbtools/utils/console.py
    rbtools/utils/users.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/resource.py
    rbtools/clients/tests.py
    rbtools/commands/setup_repo.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/utils/filesystem.py
    rbtools/utils/console.py
    rbtools/utils/users.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (377a55d)