Make a bunch of smaller 2to3 related refactors.
Review Request #6681 — Created Dec. 7, 2014 and submitted
This change makes a bunch of small updates to bring code into compliance with
both Python 2.x and 3.x.
- Ran unit tests.
- Posted some changes.
| Description | From | Last Updated |
|---|---|---|
|
We can probably improve on the old and new design by using itertools.chain(...) on these. |
 chipx86
|
|
|
Minor thing, but can we put the generator lines on a new line, like: num_files_in_diffs = len([ line ... ]) … |
chipx86
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
 reviewbot
|
-
-
rbtools/clients/clearcase.py (Diff revision 1) We can probably improve on the old and new design by using
itertools.chain(...)on these. -
rbtools/clients/tests.py (Diff revision 1) Minor thing, but can we put the generator lines on a new line, like:
num_files_in_diffs = len([ line ... ])Only reason Review Bot isn't complaining is because the lines happen to be a multiple of 4.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+41 -19) |
-
Tool: Pyflakes Processed Files: rbtools/api/resource.py rbtools/clients/tests.py rbtools/commands/setup_repo.py rbtools/commands/main.py rbtools/commands/__init__.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/utils/filesystem.py rbtools/utils/console.py rbtools/utils/users.py Tool: PEP8 Style Checker Processed Files: rbtools/api/resource.py rbtools/clients/tests.py rbtools/commands/setup_repo.py rbtools/commands/main.py rbtools/commands/__init__.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/utils/filesystem.py rbtools/utils/console.py rbtools/utils/users.py
Tool: Pyflakes Processed Files: rbtools/api/resource.py rbtools/clients/tests.py rbtools/commands/setup_repo.py rbtools/commands/main.py rbtools/commands/__init__.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/utils/filesystem.py rbtools/utils/console.py rbtools/utils/users.py Tool: PEP8 Style Checker Processed Files: rbtools/api/resource.py rbtools/clients/tests.py rbtools/commands/setup_repo.py rbtools/commands/main.py rbtools/commands/__init__.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/utils/filesystem.py rbtools/utils/console.py rbtools/utils/users.py