Summary

Fix up API tests to handle 2-to-3 conversion.

Review Request #6674 — Created Dec. 4, 2014 and submitted Dec. 8, 2014, 6:16 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

3879692...

Reviewers

Groups

rbtools

People

Description

Fix up API tests to handle 2-to-3 conversion.

This change makes a couple changes to the API interface tests. The first is a
change to use six.iteritems when iterating over a dict (since Python 3.x
doesn't have an iteritems() method on dict itself). The second fixes the type
that we're passing into setlocale() to make it work correctly with both Python
2.x and 3.x.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This is a 3rd-party module. Blank line before it.	chipx86	Dec. 8, 2014, 6:13 a.m.
Can't this be b'C'?	chipx86	Dec. 8, 2014, 6:13 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py

rbtools/api/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This is a 3rd-party module. Blank line before it.
```

rbtools/api/tests.py (Diff revision 1)

The issue has been dropped. Show all issues

Can't this be b'C'?

david

Dec. 8, 2014, 6:13 a.m.

No it can't. On Python 2.x, it compares to typeof(''), which is 'str', but on Python 3.x, it checks for 'str' (which is unicode on 2.x)

Commit:

38796922940cdc3f62315521e191a01eb071587d

Diff:

Revision 2 (+4 -2)

Show changes

rbtools/api/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (8f291c0)