Restrict CSS selection to children anchor tags of a Review Request's menu bar items

Review Request #6669 — Created Dec. 2, 2014 and submitted

Information

Review Board
master
0336a25...

Reviewers

Restrict CSS selection to children anchor tags of a Review Request's menu bar items

Testing was only done on the review_export extension and all core menu functionality.

  1. Checked other dropdown menus to see if their actions worked (Close -> Submitted, Close -> Discarded)
  2. Tried the primary menu actions (actions with no dropdowns)
    a) View Diff
    b) Download Diff
    c) Review
    d) Ship It!
  3. Tested the functionality on File Attachment actions:
    a) Update
    b) Delete
    All Worked successfully.
Description From Last Updated

I think it's best to keep events comment-free, and instead move the comment to the doc comment for _onMenuClicked.

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
ML
chipx86
  1. 
      
  2. Show all issues

    I think it's best to keep events comment-free, and instead move the comment to the doc comment for _onMenuClicked.

  3. 
      
ML
ML
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
ML
Review request changed
Status:
Completed
Change Summary:
Pushed to master (528b78f)