Restrict CSS selection to children anchor tags of a Review Request's menu bar items
Review Request #6669 — Created Dec. 2, 2014 and submitted
| Information | |
|---|---|
| mloyzer | |
| Review Board | |
| master | |
| 0336a25... | |
| Reviewers | |
| reviewboard, students | |
Restrict CSS selection to children anchor tags of a Review Request's menu bar items
Testing was only done on the review_export extension and all core menu functionality.
- Checked other dropdown menus to see if their actions worked (Close -> Submitted, Close -> Discarded)
- Tried the primary menu actions (actions with no dropdowns)
a) View Diff
b) Download Diff
c) Review
d) Ship It!- Tested the functionality on File Attachment actions:
a) Update
b) Delete
All Worked successfully.
| Description | From | Last Updated |
|---|---|---|
|
I think it's best to keep events comment-free, and instead move the comment to the doc comment for _onMenuClicked. |
 chipx86
|
-
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1) I think it's best to keep
eventscomment-free, and instead move the comment to the doc comment for_onMenuClicked.
ML
Change Summary:
Updated testing done to include file attachments.
Testing Done: |
|
|---|
ML
Change Summary:
Move comment to function definition
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+3 -1) |
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/reviewRequestEditorView.js