Summary

Fixed PEP-8 formatting recommendations in utils module

Review Request #6667 — Created Dec. 2, 2014 and discarded Dec. 2, 2014, 1:58 p.m.

Information

Owner

justy777

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools, students

People

Description

This fixes a series of warnings from the pep8 tool involving line lengths, too many blank lines, and imporper spacing.

Testing Done

Ran tests, and pep8.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Dec. 2, 2014, 1:28 p.m.
Col: 80 E501 line too long (98 > 79 characters)	reviewbot	Dec. 2, 2014, 1:28 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Dec. 2, 2014, 1:28 p.m.
Col: 80 E501 line too long (104 > 79 characters)	reviewbot	Dec. 2, 2014, 1:28 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	Dec. 2, 2014, 1:28 p.m.
'win32com' imported but unused	reviewbot	Dec. 2, 2014, 1:29 p.m.
'windll' imported but unused	reviewbot	Dec. 2, 2014, 1:29 p.m.
'com' imported but unused	reviewbot	Dec. 2, 2014, 1:29 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/utils/appdirs.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/appdirs.py

rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (98 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (104 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

We don't maintain appdirs.py. We just bundle it. We should keep it exactly as it was upstream, in order to help see differences when we go to replace the version down the road.

In other words, this change should be discarded.

Review Board 7.0 alpha 0 (dev)

Fixed PEP-8 formatting recommendations in utils module

Information

Reviewers

Status: Discarded

rbtools/utils/appdirs.py (Diff revision 1)

rbtools/utils/appdirs.py (Diff revision 1)

rbtools/utils/appdirs.py (Diff revision 1)

rbtools/utils/appdirs.py (Diff revision 1)