Fixed PEP-8 formatting recommendations in clients module

Review Request #6664 — Created Dec. 2, 2014 and submitted

Information

RBTools
master
0eb3327...

Reviewers

This fixes a series of warnings from the pep8 tool involving line lengths, too many blank lines, and under-indented lines.

Ran unit tests, and pep8.

Description From Last Updated

I'd prefer the original way, but move log and re.M to the next line.

chipx86chipx86

RBTools tests don't work with wrapped docstrings like the RB ones do. These all need to be reverted.

chipx86chipx86

I'd prefer keeping the indentation as it was, but move the extra_ignore_errors to a new line.

chipx86chipx86

Col: 80 E501 line too long (90 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (131 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (84 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (88 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/tests.py
        rbtools/clients/clearcase.py
        rbtools/clients/plastic.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
        rbtools/clients/perforce.py
        rbtools/clients/bazaar.py
        rbtools/clients/svn.py
    
    Ignored Files:
        AUTHORS
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/tests.py
        rbtools/clients/clearcase.py
        rbtools/clients/plastic.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
        rbtools/clients/perforce.py
        rbtools/clients/bazaar.py
        rbtools/clients/svn.py
    
    Ignored Files:
        AUTHORS
    
    
  2. 
      
chipx86
  1. 
      
  2. rbtools/clients/git.py (Diff revision 1)
     
     
     
    Show all issues

    I'd prefer the original way, but move log and re.M to the next line.

  3. rbtools/clients/tests.py (Diff revision 1)
     
     
     
    Show all issues

    RBTools tests don't work with wrapped docstrings like the RB ones do.

    These all need to be reverted.

  4. rbtools/clients/tests.py (Diff revision 1)
     
     
     
     
    Show all issues

    I'd prefer keeping the indentation as it was, but move the extra_ignore_errors to a new line.

  5. 
      
justy777
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/tests.py
        rbtools/clients/clearcase.py
        rbtools/clients/plastic.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
        rbtools/clients/perforce.py
        rbtools/clients/bazaar.py
        rbtools/clients/svn.py
    
    Ignored Files:
        AUTHORS
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/tests.py
        rbtools/clients/clearcase.py
        rbtools/clients/plastic.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
        rbtools/clients/perforce.py
        rbtools/clients/bazaar.py
        rbtools/clients/svn.py
    
    Ignored Files:
        AUTHORS
    
    
  2. rbtools/clients/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (90 > 79 characters)
    
  3. rbtools/clients/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  4. rbtools/clients/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (131 > 79 characters)
    
  5. rbtools/clients/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (84 > 79 characters)
    
  6. rbtools/clients/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  7. rbtools/clients/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (88 > 79 characters)
    
  8. rbtools/clients/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  9. 
      
david
  1. Ship It!
  2. 
      
justy777
Review request changed
Status:
Completed
Change Summary:
Pushed to master (f820cc5)