Fixed PEP-8 formatting recommendations in clients module
Review Request #6664 — Created Dec. 2, 2014 and submitted
| Information | |
|---|---|
| justy777 | |
| RBTools | |
| master | |
| 0eb3327... | |
| Reviewers | |
| rbtools, students | |
This fixes a series of warnings from the pep8 tool involving line lengths, too many blank lines, and under-indented lines.
Ran unit tests, and pep8.
| Description | From | Last Updated |
|---|---|---|
|
I'd prefer the original way, but move log and re.M to the next line. |
 chipx86
|
|
|
RBTools tests don't work with wrapped docstrings like the RB ones do. These all need to be reverted. |
chipx86
|
|
|
I'd prefer keeping the indentation as it was, but move the extra_ignore_errors to a new line. |
chipx86
|
|
|
Col: 80 E501 line too long (90 > 79 characters) |
 reviewbot
|
|
|
Col: 80 E501 line too long (87 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (131 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (93 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (92 > 79 characters) |
reviewbot
|
-
-
rbtools/clients/git.py (Diff revision 1) I'd prefer the original way, but move
logandre.Mto the next line. -
rbtools/clients/tests.py (Diff revision 1) RBTools tests don't work with wrapped docstrings like the RB ones do.
These all need to be reverted.
-
rbtools/clients/tests.py (Diff revision 1) I'd prefer keeping the indentation as it was, but move the
extra_ignore_errorsto a new line.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+50 -51) |
-
Tool: Pyflakes Processed Files: rbtools/clients/tests.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/clients/mercurial.py rbtools/clients/git.py rbtools/clients/perforce.py rbtools/clients/bazaar.py rbtools/clients/svn.py Ignored Files: AUTHORS Tool: PEP8 Style Checker Processed Files: rbtools/clients/tests.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/clients/mercurial.py rbtools/clients/git.py rbtools/clients/perforce.py rbtools/clients/bazaar.py rbtools/clients/svn.py Ignored Files: AUTHORS -
-
-
-
-
-
-
Tool: Pyflakes Processed Files: rbtools/clients/tests.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/clients/mercurial.py rbtools/clients/git.py rbtools/clients/perforce.py rbtools/clients/bazaar.py rbtools/clients/svn.py Ignored Files: AUTHORS Tool: PEP8 Style Checker Processed Files: rbtools/clients/tests.py rbtools/clients/clearcase.py rbtools/clients/plastic.py rbtools/clients/mercurial.py rbtools/clients/git.py rbtools/clients/perforce.py rbtools/clients/bazaar.py rbtools/clients/svn.py Ignored Files: AUTHORS