Short-circuit diff patching for moved files with no changes.

Review Request #6655 — Created Dec. 1, 2014 and submitted

Information

Review Board
release-2.0.x
45b7ddc...

Reviewers

The comment for DiffChunkGenerator.get_chunks() indicates that moved files
with no changes should be returned as an empty list without actually fetching
source files or applying patches, but this wasn't the case. This change fixes
the conditional to return the empty list.

  • Tested a moved file with no changes. Saw that it displayed correctly without
    ever calling out to 'patch'
  • Tested a moved+edited file. Saw that it displayed correctly.
  • Ran unit tests.
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (2a21327)
Loading...