Fixes bug #3613 that causes tabs to appear in the subject line of emails

Review Request #6647 — Created Nov. 27, 2014 and submitted

justy777
Review Board
master
3613
0813f4d...
reviewboard, students

Python 2.7 has a problem that causes tabs to be used to break up long headers instead of spaces. When Review Board sends an email with a Subject longer than 62 characters, it inserts a tab to seperate the text into mutiple lines.

Now instead of the Subject header being seperatated by tabs it is seperated by spaces.

Ran unit tests.

Description From Last Updated

Should be a single import statement.

chipx86chipx86

Not very useful, since it's just saying exactly what the code is saying.

chipx86chipx86

Seems this could probably just be: email.header.Header.__init__ = _unified_header_init Can you try that and see?

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/email.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/email.py
    
    
  2. 
      
justy777
justy777
justy777
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/email.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/email.py
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/notifications/email.py (Diff revision 2)
     
     
     

    Should be a single import statement.

  3. reviewboard/notifications/email.py (Diff revision 2)
     
     

    Not very useful, since it's just saying exactly what the code is saying.

  4. reviewboard/notifications/email.py (Diff revision 2)
     
     

    Seems this could probably just be:

    email.header.Header.__init__ = _unified_header_init
    

    Can you try that and see?

  5. 
      
justy777
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/email.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/email.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
justy777
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (c31bdf5)
Loading...