Fixes bug #3613 that causes tabs to appear in the subject line of emails
Review Request #6647 — Created Nov. 26, 2014 and submitted
| Information | |
|---|---|
| justy777 | |
| Review Board | |
| master | |
| 3613 | |
| 0813f4d... | |
| Reviewers | |
| reviewboard, students | |
Python 2.7 has a problem that causes tabs to be used to break up long headers instead of spaces. When Review Board sends an email with a Subject longer than 62 characters, it inserts a tab to seperate the text into mutiple lines.
Now instead of the Subject header being seperatated by tabs it is seperated by spaces.
Ran unit tests.
Summary: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+15) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/email.py Tool: Pyflakes Processed Files: reviewboard/notifications/email.py
-
-
-
reviewboard/notifications/email.py (Diff revision 2) Not very useful, since it's just saying exactly what the code is saying.
-
reviewboard/notifications/email.py (Diff revision 2) Seems this could probably just be:
email.header.Header.__init__ = _unified_header_initCan you try that and see?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+14 -1) |
Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/email.py Tool: Pyflakes Processed Files: reviewboard/notifications/email.py