Summary:

[WIP] Support creation of multi-commit review request with the Git SCMClient

Review Request #6645 — Created Nov. 25, 2014 and discarded Jan. 6, 2015, 11:02 a.m.

Information
Owner:	brennie
Repository:	RBTools
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	rbtools, students
People:

Description

Add the -H and --with-history options to the post command, which
allow creation of a multi-commit review request if the repository's
SCMClient supports it.

Currently no SCMClients support the -H flag.

Add the SCMClient.get_revision_history method which calculates the
revision history of the provided revision dictionary. It produces a
list of revision dictionaries that can be used to create diffs for
each commit in the range of commits.

Add an implementation of get_revision_history for the Git SCMClient.

Testing Done

Running rbt post -H ... with any SCMClient fails.

Unit tests pass.

Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py
    rbtools/clients/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py
    rbtools/clients/__init__.py

Change Summary:

Add students group

Groups:

+	students

Change Summary:

Add history calculation for Git.

Summary:

-	[WIP] Add the -H/--with-history to the rbt post command to create posts with history
+	[WIP] Support creation of multi-commit review request with the Git SCMClient

Description:

~		The `-H` option allows creation of a multi-review commit request with
~		SCMClients that support it. For those that support it, a review request
	~	Add the `-H` and '--with-history' options, which allow creation of a
	~	multi-commit review request if the repository's SCMClient supports it.
-		will be created for each commit in the revision spec.

		Currently no SCMClients support the `-H` flag.
	+
	+	Add the `SCMClient.get_revision_history` method which calculates the
	+	revision history of the provided revision dictionary. It produces a
	+	list of revision dictionaries that can be used to create diffs for
	+	each commit in the range of commits.
	+
	+	Add an implementation of `get_revision_history` for the Git SCMClient.

Testing Done:

~		Could not create a post using `-H` using any SCMClient.
	~	Running `rbt post -H ...` with any SCMClient fails.
	+
	+	Unit tests pass.

Commit:

-	a20efdc4580d73b378ff95465f9f270439de7e0e
+	51628f56c6209a7ee7f8650b0f4b63b9b3f56233

Diff:

Revision 2 (+69)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/git.py
	rbtools/clients/tests.py
	rbtools/commands/post.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py
    rbtools/clients/git.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py
    rbtools/commands/post.py
    rbtools/clients/__init__.py
    rbtools/clients/git.py

Change Summary:

Formatting.

Description:

~		Add the `-H` and '--with-history' options, which allow creation of a
~		multi-commit review request if the repository's SCMClient supports it.
	~	Add the `-H` and `--with-history` options to the post command, which
	~	allow creation of a multi-commit review request if the repository's
	+	SCMClient supports it.

		Currently no SCMClients support the `-H` flag.

		Add the `SCMClient.get_revision_history` method which calculates the
		revision history of the provided revision dictionary. It produces a
		list of revision dictionaries that can be used to create diffs for
		each commit in the range of commits.

		Add an implementation of `get_revision_history` for the Git SCMClient.

Review Board 6.0 beta 3 (dev)

[WIP] Support creation of multi-commit review request with the Git SCMClient

Change Summary:

Groups:

Change Summary:

Summary:

Description:

Testing Done:

Commit:

Diff:

Change Summary:

Description:

Status: Discarded